GDScript: Clear base script in GDScript::clear#117991
Open
NoctemCat wants to merge 1 commit into
Open
Conversation
NoctemCat
force-pushed
the
clear_base_before_next
branch
from
1e93251 to
0388291
Compare
NoctemCat
changed the title
GDScript::clear
HolonProduction
approved these changes
Apr 28, 2026
Member
HolonProduction
left a comment
HolonProduction
left a comment
There was a problem hiding this comment.
Can confirm that this fixes the issue. The approach makes sense to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #117975
We can access an already freed script when clearing dependencies between scripts. It can happen because sometimes the reference to the base script can be the last reference and at the same time the next one in the
script_list. So we first advance list to the next node and then free the base script in theRef<GDScript> scrdestructor.To fix it I choose to manually clear the base script before moving to the next node to allow it to remove itself from thescript_listif it needs to.As recommended in Rocket chat the code to clean it was moved to
GDScript::clear. It was still tested with tsan build and it also fixes it.Tbh, not sure how often it happens, but it does happen in my project and in the mrp at least.