Use all GeometryInstance3D nodes when calculating a scene AABB#118690
Open
aaronfranke wants to merge 1 commit into
Open
Use all GeometryInstance3D nodes when calculating a scene AABB#118690aaronfranke wants to merge 1 commit into
aaronfranke wants to merge 1 commit into
Conversation
aaronfranke
force-pushed
the
visual-inst-scene-aabb
branch
from
b308371 to
f8c3cdb
Compare
aaronfranke
force-pushed
the
visual-inst-scene-aabb
branch
from
f8c3cdb to
92f7787
Compare
aaronfranke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing PR #112866, there were errors printed to the console because MultiMeshInstance3D nodes weren't being considered in the scene AABB calculation. This PR changes the code to look at all
GeometryInstance3Dnodes. Note that I did not useVisualInstance3Dso that the radius of lights are excluded in this calculation.Additionally, if a scene contains no geometry, the errors would still be printed. Therefore, I also changed the starting AABB to be a very tiny AABB around the origin, rather than being a zero-size AABB.