Skip to content

Add grabber_max_size theme item to Slider#119490

Open
Arnklit wants to merge 1 commit into
godotengine:masterfrom
Arnklit:slider-grabber-max-size
Open

Add grabber_max_size theme item to Slider#119490
Arnklit wants to merge 1 commit into
godotengine:masterfrom
Arnklit:slider-grabber-max-size

Conversation

@Arnklit
Copy link
Copy Markdown
Contributor

@Arnklit Arnklit commented May 15, 2026

What problem(s) does this PR solve?

Closes godotengine/godot-proposals#14849

Additional information

This adds a grabber_max_size theme item to slider that allows you to limit that grabber icon's size similar to how icon_max_width does for Button.

godot.windows.editor.dev.x86_64_UaKd6eetiR.mp4

Example project:
slider_grabber_max_size_example_2026-05-15_13-56-02.zip

@Arnklit Arnklit requested review from a team as code owners May 15, 2026 12:57
@Arnklit Arnklit force-pushed the slider-grabber-max-size branch from 3f9b16d to 80841df Compare May 15, 2026 13:10
Comment thread doc/classes/Slider.xml Outdated
@AThousandShips AThousandShips added this to the 4.x milestone May 15, 2026
@Arnklit Arnklit force-pushed the slider-grabber-max-size branch from 80841df to dcce1e2 Compare May 15, 2026 14:14
@akien-mga akien-mga changed the title Add grabber_max_size theme item to Slider Add grabber_max_size theme item to Slider May 18, 2026
@Arnklit Arnklit force-pushed the slider-grabber-max-size branch 2 times, most recently from 93147ee to d804c5d Compare May 20, 2026 11:45
@Arnklit
Copy link
Copy Markdown
Contributor Author

Arnklit commented May 20, 2026

I realised that the Tick icon was also missing a max size, so it had the same limitation, so I added it in here as well. So with both of these together it allows you to use the same grabber and tick icons to make sliders with varying sizes without having separate different sized copies of the icon textures.

image

Updated example project:
slider_grabber_max_size_example_2026-05-20_12-48-08.zip

@Arnklit Arnklit force-pushed the slider-grabber-max-size branch from d804c5d to 37e778d Compare May 20, 2026 12:02
@Arnklit Arnklit force-pushed the slider-grabber-max-size branch from 37e778d to f7879a8 Compare June 3, 2026 13:20
@Arnklit Arnklit force-pushed the slider-grabber-max-size branch from f7879a8 to e4c6ab9 Compare June 3, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to scale grabber icon on Slider controls with theme

2 participants