Add tests to Image -- rotate_90(), rotate_180() and decompress()#119881
Open
Spudoku wants to merge 10 commits into
Open
Add tests to Image -- rotate_90(), rotate_180() and decompress()#119881Spudoku wants to merge 10 commits into
Image -- rotate_90(), rotate_180() and decompress()#119881Spudoku wants to merge 10 commits into
Conversation
…fset_polygon, triangulate_delaunay and triangulate_polygon
collinear lines and zero-area polygons are valid apparently?
These include: - cases of non-square images - Idempotecy cases (multiple rotations equalling rotate_180(), the original data, or a single counterclockwise rotation)
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
Otherwise I think this looks good conceptually, but the relevant teams will have to review as well
Also attempted to address memory leaks found in "Linux / Editor with doubles and GCC sanitizers (target=editor, dev_build=yes, scu_build=yes, precision=double, use_asan=yes, use_ubsan=yes, linker=mold)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
link to issue #43440
Adds unit tests for the
Imageclass, specifically for its methodsrotate_90(),rotate_180()anddecompress()AI was used for code feedback, but not for writing code.