Skip to content

GDScript: Remove unused code in GDScriptFunctionState#119931

Open
dalexeev wants to merge 1 commit into
godotengine:masterfrom
dalexeev:gds-remove-unused-code-gds-func-state
Open

GDScript: Remove unused code in GDScriptFunctionState#119931
dalexeev wants to merge 1 commit into
godotengine:masterfrom
dalexeev:gds-remove-unused-code-gds-func-state

Conversation

@dalexeev
Copy link
Copy Markdown
Member

@dalexeev dalexeev commented Jun 1, 2026

What problem(s) does this PR solve?

The resume() and is_valid() methods are leftovers from 3.x, when GDScriptFunctionState was exposed. Since that's no longer the case, we can remove them from _bind_methods() and remove is_valid() entirely.

Additional information

None.

@dalexeev dalexeev added this to the 4.8 milestone Jun 1, 2026
@dalexeev dalexeev requested a review from a team as a code owner June 1, 2026 07:59
Comment thread modules/gdscript/gdscript_function.h Outdated
@dalexeev dalexeev force-pushed the gds-remove-unused-code-gds-func-state branch from af8fbe4 to cdee474 Compare June 1, 2026 13:43
Copy link
Copy Markdown
Member

@HolonProduction HolonProduction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants