Don't use CreateCommandList1 on D3D12.#119971
Merged
Repiteo merged 1 commit intoJun 2, 2026
Merged
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the usage of CreateCommandList1 on the D3D12 driver introduces a failure point for devices that might report the Device4 API as supported, but fail to create the command list when called. While this is not expected behavior, I've found it to happen on some devices.
Apart from that, it seems the command allocator is created regardless of whether this API is used, which it doesn't require, and probably leads to two command allocators being created per command buffer: one that goes unused and one internally by the driver.Upon further review, it seems this is only necessary because it has to create the command list in an open state. It still requires the command allocator to begin the command list.I couldn't find much benefit or difference to using the newer API here instead of the safer option.