Merge the two Object mutexes to save on RAM (1/4 down).#119985
Open
Ivorforce wants to merge 1 commit into
Open
Merge the two Object mutexes to save on RAM (1/4 down).#119985Ivorforce wants to merge 1 commit into
Object mutexes to save on RAM (1/4 down).#119985Ivorforce wants to merge 1 commit into
Conversation
mihe
reviewed
Jun 4, 2026
Comment on lines
-71
to
+72
| Mutex *mutex1 = nullptr; | ||
| Mutex *mutex2 = nullptr; | ||
| BinaryMutex *mutex1 = nullptr; | ||
| BinaryMutex *mutex2 = nullptr; |
Contributor
There was a problem hiding this comment.
There are code paths that lock recursively, so changing to BinaryMutex will presumably cause a deadlock. See Object::_add_user_signal and Object::add_user_signal.
There might be more, I'm not sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
Reduces non-
NodeObjectsize by ~88 bytes, which is around 1/4 of their total size (assuming empty).Additional information
There's no real need to have two separate mutexes. Access to both is rare, and mutexes are huge.
Performance should be the same as before, or better.
Objectinstantiation should be measurably faster (no additional allocation).Note: Mostly untested right now (except for a quick compile and unit test/editor run).
The main risk I see is if I misinterpreted the
signalcode and this change introduces some deadlock potential.Objectsignals #117511.