Add unit tests for AnimationNodeAnimation#119988
Open
chocola-mint wants to merge 1 commit into
Open
Conversation
chocola-mint
force-pushed
the
animation-blend-tree-tests
branch
from
a12d425 to
519109f
Compare
TokageItLab
requested changes
Jun 3, 2026
| animation.instantiate(); | ||
| Ref<AnimationLibrary> animation_library; | ||
| animation_library.instantiate(); | ||
| animation_library->add_animation(test_animation_name, animation); |
Member
There was a problem hiding this comment.
As I mentioned in #119980, we should add cases where the duration is not 1.0 seconds (default value).
Contributor
Author
There was a problem hiding this comment.
I have updated the test cases to use a duration of 8 seconds instead of 1.
This is done by scaling every keyframe's time by 8.
chocola-mint
force-pushed
the
animation-blend-tree-tests
branch
from
519109f to
09cbbde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
AnimationNodeAnimation's custom timeline processing logic compatible withAnimationMixer#119871Additional information
This PR adds much-needed unit tests to catch regressions involved with
AnimationNodeAnimation. Almost all playback patterns (including custom timelines) are covered with this PR.I've verified that these tests used to fail before #119871 was merged and are now passing.
Note that blending is beyond the scope of this PR and is not tested. (So there's only one
AnimationNodeAnimationinstance here) This can be future work for other contributors.