Tweak default BaseMaterial3D deep parallax quality to improve performance#57776
Closed
Calinou wants to merge 1 commit into
Closed
Tweak default BaseMaterial3D deep parallax quality to improve performance#57776Calinou wants to merge 1 commit into
Calinou wants to merge 1 commit into
Conversation
…ance On a GTX 1080 in 2560×1440, this reduces frame times by 0.25 ms on a test scene with 4 different materials that have Deep Parallax enabled. There is a subtle visual difference, but it's not too noticeable on most materials.
Contributor
Member
Author
|
I've thought about this PR again when working on #97646, but now that I look at it again, the defaults proposed by this PR look bad at high resolutions (especially 4K). This will only become more of a problem as screen resolutions keep increasing in the future. Therefore, I'll close this for now but this could be revisited later with different settings. Feel free experiment on your own 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a GTX 1080 in 2560×1440, this reduces frame times by 0.25 ms on a test scene with 4 different materials that have Deep Parallax enabled.
There is a subtle visual difference, but it's not too noticeable on most materials.
Note: This should be re-assessed if #50377 is merged, as we may not be able to reduce the number of steps as much without losing too much quality.
Testing project: https://github.com/Calinou/godot-parallax-test-4.0/tree/performance-test-master
Preview
Click to view at full size.
Before
After