Allow double-click within tracks to set a new play position

[SanNull]

This feature allows the user to move the Animation Play Position by double clicking, being more intuitive and improving workflow by keeping the mouse on the tracks, as opposed to going at the top only to change its current position.

[akien-mga]

Thanks for the contribution, and welcome! I've assigned the Animation team to assess the proposal.

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

[AdriaandeJongh]

Considering snapping the play position to frames is also applied everywhere else where you move the play position, wouldn't it make sense if this feature also snapped?

[SanNull]

wouldn't it make sense if this feature also snapped?

Snapping works just the same with it. I assume the signal timeline_changed handles the snapping (if enabled). Here's an example

[SanNull]

I know this might be late, however since it's a small quality of life feature, could this be pushed to Godot 4.4? I assume it does not conflict with other systems.

[fire]

I aspire to get this reviewed and in for 4.5.

[TokageItLab]

It makes sense as an operation and is a good idea.

However, since the selection cancellation action is similar to a double-click, so it would be necessary to make sure that there is no selection (means this should be into the if (!selected && !editor->is_selection_active()) block).

[SanNull]

@TokageItLab if we use !editor->is_selection_active() that means we can't double click on a selected keyframe that is stationary. So I opted to insert the block of code into if (!moving_selection). I'd also like to ask how probable it is currently for a double click to be misinterpreted as a selection cancellation by the animation player.

[TokageItLab]

It may be solved by adding an additional determination if the click is on a key or not. The case to be avoided is, for example, when a right-click menu is closed with a left click on a specific key, the next left click must be a key selection, not a move.

[SanNull]

I think that tracking if a keyframe was clicked to allow double clicking kinda limits the functionality (e.g if you want to go on an empty space on the track). Additionally I tested this example and double clicking was not an issue — It did not replace selection with a double click.

Is there any case where the selection consistently gets overridden by a double-click? Or a case where it double clicks and selects at the same time? I'm sorry if I'm a little slow at understanding the issue, but it's as though I'm attempting to fix something that might not be broken.

[TokageItLab]

Oh, I was looking at 4.3 and it seems that 4.3 and 4.4 already have different behavior. I don't know where this occurred, but in 4.4 the cancel action and the selection are done at the same time.

Well, considering that fewer clicks may be preferred, it appears that right-click cancellations, etc. are not a problem at this time.

However, I found one problematic behavior: multiple selections with Shift may be made by double-clicking to deselect (at the same time deselecting and seeking occur and become hard to see), so you should need to check that no mod keys (Shift/Alt/Ctrl) are pressed. Also, I think the same changes need to be made to BezierEditor for consistency.

The change request is above two things.

[SanNull]

• Double clicking now works both on the Track Editor as well as the Bezier Editor:

• If one of the mod keys (Shift/Alt/Ctrl) are pressed, double click will not be allowed.

[Repiteo]

Thanks!