chore: fix go.mod add go.work #1426
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path were relative to the root of the project. This caused an error when the repository was named something else than "gofr".
You can use the following command to sync all go.mod and go.sum files: $ go work sync
ccoVeille
changed the title
|
Please note the so the CI about "sub modules" should be removed Let's talk about it here. |
ccoVeille
commented
Jan 21, 2025
| replace gofr.dev => ../../../../../../gofr | ||
| toolchain go1.23.4 | ||
|
|
||
| replace gofr.dev => ../../../../.. |
There was a problem hiding this comment.
Guys, please help me to figure out why this was kept here, and not in other modules
It looks like a left behind thing
|
I think the next step should be done:
Everything works without them now there is a go.work file |
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative path in go.mod used in file datasource modules
This caused an error when the repository was named something else than "gofr".
Please note, I'm not even sure there is a logic to use relative path now the dev is over.
Also add missing go.work files
I'm not even sure how the project could be managed without this.
I'm sure there are some part of the CI that could be deleted now the go.work file is present