-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add test case and improved coverage for datasource/file/s3 #2441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Umang01-hash
merged 8 commits into
gofr-dev:development
from
gourish25:EN/test-datasource-file-s3
Oct 30, 2025
Merged
add test case and improved coverage for datasource/file/s3 #2441
Umang01-hash
merged 8 commits into
gofr-dev:development
from
gourish25:EN/test-datasource-file-s3
Oct 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r into EN/test-datasource-file-s3
Umang01-hash
requested changes
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please remove all
if-elseconditions from the test methods and break them into smaller methods if needed for success and error cases.
Umang01-hash
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description:
Additional Information:
Tests use mock objects for S3 client
Testify assertions used for better test readability
Helper functions created for consistent test setup
Checklist:
Thank you for your contribution!