Skip to content

feat: add session_timeout and token_expiration options for config system - #624

Open
cyberm8 wants to merge 2 commits into
goharbor:mainfrom
cyberm8:main
Open

feat: add session_timeout and token_expiration options for config system#624
cyberm8 wants to merge 2 commits into
goharbor:mainfrom
cyberm8:main

Conversation

@cyberm8

@cyberm8 cyberm8 commented Jul 28, 2026

Copy link
Copy Markdown

Added config system option "session_timeout".
Added config system_option "token_expiration".

@cyberm8
cyberm8 requested a review from a team as a code owner July 28, 2026 08:49
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@flbla

flbla commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@cyberm8

cyberm8 commented Jul 30, 2026

Copy link
Copy Markdown
Author

Sorry, I made two mistakes.

First, I wanted to create 2 distinct PRs, second, I did not notice token expiration was already partially defined in auth settings.

I think the build is fixed now.

I don't know a lot about go, and if there is any official way to actually test the code, but I managed to use the locally compiled provider on my Harbor instance.

terraform plan

Terraform will perform the following actions:

  # harbor_config_system.main will be updated in-place
  ~ resource "harbor_config_system" "main" {
        id                             = "configuration/system"
      ~ session_timeout                = 10080 -> 60
      ~ token_expiration               = 300 -> 30
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }


terraform apply

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

harbor_config_system.main: Modifying... [id=configuration/system]
harbor_config_system.main: Modifications complete after 0s [id=configuration/system]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

@cyberm8 cyberm8 changed the title feat: add session_timeout option for config system feat: add session_timeout and token_expiration options for config system Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants