This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Updated dependencies. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturdryomov
approved these changes
May 13, 2018
yunikkk
force-pushed
the
update-dependencies
branch
from
bac30b8 to
9dfe97e
Compare
artem-zinnatullin
suggested changes
May 13, 2018
| @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.4-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-bin.zip | |||
There was a problem hiding this comment.
pls run something with Gradle to update the wrapper, also you can use 4.7
There was a problem hiding this comment.
Well, wrapper isn't updating, Ive ran it many times...
yunikkk
commented
May 14, 2018
| @@ -36,9 +36,10 @@ docker run \ | |||
| --env BINTRAY_USER="$BINTRAY_USER" \ | |||
| --env BINTRAY_API_KEY="$BINTRAY_API_KEY" \ | |||
| --env BINTRAY_GPG_PASSPHRASE="$BINTRAY_GPG_PASSPHRASE" \ | |||
| --env ANDROID_HOME="" \ | |||
There was a problem hiding this comment.
Sad workaround for NPE when accessing adb in tests, with new commander
when ANDROID_HOME is not set.
There was a problem hiding this comment.
Or we could wrap them locally...
There was a problem hiding this comment.
ouch, well ok for now I guess
artem-zinnatullin
approved these changes
May 14, 2018
| @@ -36,9 +36,10 @@ docker run \ | |||
| --env BINTRAY_USER="$BINTRAY_USER" \ | |||
| --env BINTRAY_API_KEY="$BINTRAY_API_KEY" \ | |||
| --env BINTRAY_GPG_PASSPHRASE="$BINTRAY_GPG_PASSPHRASE" \ | |||
| --env ANDROID_HOME="" \ | |||
There was a problem hiding this comment.
ouch, well ok for now I guess
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37