Implement HasFIPSProvider #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
karianna,
derekparker,
dagood,
mertakman and
gdams
mertakman
reviewed
Nov 4, 2024
mertakman
reviewed
Nov 4, 2024
mertakman
approved these changes
Nov 4, 2024
|
I'm retiring this PR for now. It was primary targeted to workaround an issue when using AZL3 + SymCrypt +FIPS, and it may be finally fixed in AZL3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS()will return false if thefips=yesproperty is not set in the default properties. This is working as intended, but it is not sufficient to determine if the provider used by default is FIPS-capable. Some distros (e.g. Azure Linux 3, see microsoft/azurelinux#10433) don't set the-fips=yesproperty when operating in FIPS mode, but instead set a FIPS-capable provider (e.g. SymCrypt) as default provider by setting theproviderproperty in the default properties (e.g.?provider=symcryptprovider).This PR adds a new function,
HasFIPSProvider(), which checks if the provider used by the default matches thefips=yesquery.