Add OracleDB support to golang-migrate#1230
Open
JailtonJunior94 wants to merge 1 commit intogolang-migrate:masterfrom
Open
Add OracleDB support to golang-migrate#1230JailtonJunior94 wants to merge 1 commit intogolang-migrate:masterfrom
JailtonJunior94 wants to merge 1 commit intogolang-migrate:masterfrom
Conversation
pedRo-shd
approved these changes
Mar 6, 2025
alexteza
approved these changes
Mar 12, 2025
mauri870
reviewed
Mar 13, 2025
| var ( | ||
| specs = []dktesting.ContainerSpec{ | ||
| { | ||
| ImageName: "gvenzl/oracle-free:23.5-slim", Options: oracleOptions(), |
There was a problem hiding this comment.
I'm not familiar with OracleDB, but is it possible to use an official Docker image? Most of the other database tests use official images.
|
Good one, waiting to be approved. |
|
follow up on this |
|
@dhui what needs to be done to make this happen? This feature has a lot of interest, it would surely make many people happy. My team is currently working on a project where Oracle Database is meant to store critical data. We chose to run Flyway in an init container (in Kubernetes environment). While it sure works, it makes lots of things way more complicated. Is there any way that we can help with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add OracleDB support to golang-migrate
This PR implements support for OracleDB in golang-migrate. The main changes include:
Open,Close,Lock,Unlock,Run,SetVersion,Version, andDrop.How to Test: