x/crypto: increasing the default BCrypt cost#326
x/crypto: increasing the default BCrypt cost#326n-bruno wants to merge 1 commit intogolang:masterfrom
Conversation
Upgrade Bcrypt DefaultCost from 10 to 12 to match PHP's bcrypt library. See PHP's RFC for research: https://wiki.php.net/rfc/bcrypt_cost_2023
|
This PR (HEAD: aa23a5e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/710876. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/710876. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/710876. |
|
Message from Sean Liao: Patch Set 2: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/710876. |
|
Message from N: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/710876. |
Looking at git blame, it appears the DefaultCost for the Bcrypt library has remained unchanged for the past 14 years.
To keep up with modern hardware, I propose upgrading the Bcrypt library's DefaultCost from 10 to 12 to match the PHP 8.4 recent update in 2024.
Please see PHP's RFC for research on this topic, but please keep in mind the benchmarks are specific to PHP: https://wiki.php.net/rfc/bcrypt_cost_2023