Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsprpc: TestClientLogging failures #66865

Open
gopherbot opened this issue Apr 16, 2024 · 3 comments
Open

x/tools/gopls/internal/lsprpc: TestClientLogging failures #66865

gopherbot opened this issue Apr 16, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.19.0

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/lsprpc" && test == "TestClientLogging"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestClientLogging (1.04s)
    lsprpc_test.go:84: timeout waiting for client log
2024/04/16 21:24:33 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir/tmp/go-build49580624/b552/lsprpc.test"
	client_id="3"
2024/04/16 21:24:33 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:50483->127.0.0.1:30013: use of closed network connection
2024/04/16 21:24:44 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir/tmp/go-build49580624/b552/lsprpc.test"
	client_id="6"
2024/04/16 21:24:44 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:41672->127.0.0.1:16998: use of closed network connection
2024/04/16 21:24:44 ping
2024/04/16 21:24:44 ping

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 16, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/lsprpc" && test == "TestClientLogging"
2024-04-16 19:53 freebsd-amd64-race tools@3f74dc58 go@15cec430 x/tools/gopls/internal/lsprpc.TestClientLogging (log) 
--- FAIL: TestClientLogging (1.04s)
    lsprpc_test.go:84: timeout waiting for client log
2024/04/16 21:24:33 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir/tmp/go-build49580624/b552/lsprpc.test"
	client_id="3"
2024/04/16 21:24:33 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:50483->127.0.0.1:30013: use of closed network connection
2024/04/16 21:24:44 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir/tmp/go-build49580624/b552/lsprpc.test"
	client_id="6"
2024/04/16 21:24:44 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:41672->127.0.0.1:16998: use of closed network connection
2024/04/16 21:24:44 ping
2024/04/16 21:24:44 ping

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 16, 2024
@gopherbot gopherbot added this to the Unreleased milestone Apr 16, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 Apr 25, 2024
@findleyr
Copy link
Member

May be a real flake, or transient network failure. Moving to next release milestone.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/lsprpc" && test == "TestClientLogging"
2024-04-26 18:18 netbsd-arm64-bsiegert tools@2fa621c3 go@3f4af1ff x/tools/gopls/internal/lsprpc.TestClientLogging (log) 
--- FAIL: TestClientLogging (2.34s)
    lsprpc_test.go:84: timeout waiting for client log
2024/04/28 07:50:07 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/var/gobuilder/buildlet/tmp/go-build1262764624/b547/lsprpc.test"
	client_id="3"
2024/04/28 07:50:07 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:58821->127.0.0.1:58823: use of closed network connection
2024/04/28 07:50:35 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/var/gobuilder/buildlet/tmp/go-build1262764624/b547/lsprpc.test"
	client_id="6"
2024/04/28 07:50:35 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:58816->127.0.0.1:58817: use of closed network connection
2024/04/28 07:50:35 ping
2024/04/28 07:50:35 ping

— watchflakes

@findleyr findleyr modified the milestones: gopls/v0.16.0, gopls/v0.17.0 May 23, 2024
@findleyr findleyr modified the milestones: gopls/v0.17.0, gopls/v0.18.0 Oct 22, 2024
@findleyr findleyr modified the milestones: gopls/v0.18.0, gopls/v0.19.0 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: No status
Milestone
gopls/v0.19.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr