x/tools/gopls/internal/cache/methodsets: "missing object path for %s" bug in indexBuilder.build #70418

jacksoom · 2024-11-16T15:11:42Z

#!stacks
"runtime.gopanic" && "methodsets.(*indexBuilder).build.func2:+12" ||
 "bug.Reportf" && "(*indexBuilder).build.func2.1:+1" || // off-by-one line due to telemetry bug
 "bug.Reportf" && "(*indexBuilder).build.func2:+32"

Issue created by stacks.

		// Instantiations of generic methods don't have an
		// object path, so we use the generic.
		if p, err := objectpathFor(method.Origin()); err != nil {
			panic(err) // can't happen for a method of a package-level type
		} else {
			m.ObjectPath = b.string(string(p))
		}

First stack is here.

gopls version: v0.17.0-pre.2/go1.23.2
gopls flags:
update flags: proxy
extension version: 0.42.1
environment: Cursor darwin
initialization error: undefined
issue timestamp: Sat, 16 Nov 2024 15:11:16 GMT
restart history:
Sat, 16 Nov 2024 15:10:59 GMT: activation (enabled: true)

gopls stats -anon

{ "DirStats": { "Files": 5774, "TestdataFiles": 216, "GoFiles": 960, "ModFiles": 1, "Dirs": 516 }, "GOARCH": "arm64", "GOOS": "darwin", "GOPACKAGESDRIVER": "", "GOPLSCACHE": "", "GoVersion": "go1.23.2", "GoplsVersion": "v0.17.0-pre.2", "InitialWorkspaceLoadDuration": "1.603257166s", "MemStats": { "HeapAlloc": 318890328, "HeapInUse": 434987008, "TotalAlloc": 1358687472 }, "WorkspaceStats": { "Files": { "Total": 9784, "Largest": 4950165, "Errs": 0 }, "Views": [ { "GoCommandVersion": "go1.23.2", "AllPackages": { "Packages": 2191, "LargestPackage": 159, "CompiledGoFiles": 10309, "Modules": 322 }, "WorkspacePackages": { "Packages": 199, "LargestPackage": 54, "CompiledGoFiles": 1185, "Modules": 1 }, "Diagnostics": 0 } ] } }

Dups: yJIbcA 9nLJcw B-EmyA re0xQw VFXJYg MDN9RQ yO6-PA

The text was updated successfully, but these errors were encountered:

jacksoom · 2024-11-17T11:46:35Z

[Info  - 7:38:35 PM] 2024/11/17 19:38:35 Created View (#1)
	directory=/Users/jacksoom/programer/pell/chain
	view_type="GoMod"
	root_dir="file:///Users/jacksoom/programer/pell/chain"
	go_version="go version go1.23.2 darwin/arm64"
	build_flags=[]
	env={GOOS:darwin GOARCH:arm64 GOCACHE:/Users/jacksoom/Library/Caches/go-build GOMODCACHE:/Users/jacksoom/programer/golang/pkg/mod GOPATH:/Users/jacksoom/programer/golang GOPRIVATE:github.com/0xPellNetwork/* GOFLAGS: GO111MODULE:on GOTOOLCHAIN:auto GOROOT:/Users/jacksoom/.goenv/versions/1.23.2 GoVersion:23 GoVersionOutput:go version go1.23.2 darwin/arm64
 ExplicitGOWORK: EffectiveGOPACKAGESDRIVER:}
	env_overlay=[]

[Info  - 7:38:36 PM] 2024/11/17 19:38:36 go/packages.Load golang/vscode-go#1
	view_id="1"
	snapshot=0
	directory=/Users/jacksoom/programer/pell/chain
	query=[/Users/jacksoom/programer/pell/chain/... builtin]
	packages=261
	duration=891.908667ms

panic: can't find path for func (github.com/cosmos/cosmos-sdk/x/authz.Authorization).ValidateBasic() error in github.com/cosmos/cosmos-sdk/x/authz

jacksoom · 2024-11-17T11:46:48Z

gopls(server) output log

jacksoom · 2024-11-17T11:50:02Z

go version go1.23.2 darwin/arm64
gopls version
golang.org/x/tools/gopls v0.17.0-pre.2

jacksoom · 2024-11-17T11:54:14Z

The crash appears to be specific to this gopls version. After switching to version 0.16.2. works fine right now.

findleyr · 2024-11-18T19:01:25Z

Thank you! We will fix this for the next prerelease. Very much appreciate the report.

findleyr · 2024-11-18T19:03:11Z

@jacksoom could you please possibly include the full panicking stack? The panic message alone is not necessarily easy to track down.

Edit: see #70418 (comment); --@adonovan

findleyr · 2024-11-18T19:29:13Z

@adonovan the panic here looks like the likely culprit:
https://cs.opensource.google/go/x/tools/+/master:gopls/internal/cache/methodsets/methodsets.go;l=232;drc=1d5e334177335fd58b8eee6f809b3589bf7371aa

I can certainly imagine that some combination of aliases, generics, embedding, and importing could result in an interface method that has no objectpath. However, in that case the question is why didn't this reproduce with v0.16.2, as I don't think this logic has changed recently.

adonovan · 2024-11-18T20:07:01Z

the panic here looks like the likely culprit:

Well spotted. We should probably always augment panic(err) calls with a distinct string to make these needles easier to find in the haystack.

adonovan · 2024-11-19T15:52:58Z

This stack yJIbcA was reported by telemetry:

crash/crash
runtime.gopanic:+69
golang.org/x/tools/gopls/internal/cache/methodsets.(*indexBuilder).build.func2:+12
golang.org/x/tools/gopls/internal/cache/methodsets.methodSetInfo:+19
golang.org/x/tools/gopls/internal/cache/methodsets.(*indexBuilder).build:+35
golang.org/x/tools/gopls/internal/cache/methodsets.NewIndex:=81
golang.org/x/tools/gopls/internal/cache.(*syntaxPackage).methodsets.func1:+1
sync.(*Once).doSlow:+5
sync.(*Once).Do:=67
golang.org/x/tools/gopls/internal/cache.(*syntaxPackage).methodsets:+1
golang.org/x/tools/gopls/internal/cache.storePackageResults:+3
golang.org/x/tools/gopls/internal/cache.(*typeCheckBatch).getPackage.func1.gowrap1:+0
runtime.goexit:+0

golang.org/x/tools/[email protected] go1.23.3 linux/amd64 vscode (8)
golang.org/x/tools/[email protected] go1.23.3 linux/amd64 vscode (5)

adonovan · 2024-11-21T19:00:29Z

This is a real mystery. The error is:

panic: can't find path for func (github.com/cosmos/cosmos-sdk/x/authz.Authorization).ValidateBasic() error in github.com/cosmos/cosmos-sdk/x/authz

and the source is:

package authz // "github.com/cosmos/cosmos-sdk/x/authz"

import ( ... )

type Authorization interface {
	proto.Message
	MsgTypeURL() string
	Accept(ctx context.Context, msg sdk.Msg) (authz.AcceptResponse, error)
	ValidateBasic() error // <-- object of interest
}

Clearly objectpath.Encoder.For is getting all the way to the end without finding this method (types.Func) in the "step 4" search, yet there's nothing obviously tricky about this case. The pointer comparison in the interface method check raises the question about whether Origin is needed in case of generics, but there are no generics here:

	case *types.Interface:
		for i := 0; i < T.NumMethods(); i++ {
			m := T.Method(i)
			if f.seenMethods[m] {
				return nil
			}
			path2 := appendOpArg(path, opMethod, i)
			if m == f.obj {                                                         // sound?
				return path2 // found interface method
			}

I am unable to reproduce the crash locally while navigating this source tree.

gopherbot · 2024-11-25T21:38:33Z

Change https://go.dev/cl/631778 mentions this issue: gopls/internal/cache/methodsets: refine crash for missing object path

We can't reproduce the crash observed in golang/go#70418, where a method on a package level type name has no object path. In any case, downgrade this crash to a bug report, and refine the report to clarify some conditions potentially related to the crash. For golang/go#70418 Change-Id: If6ab38e2189accf881e84da568525e2228c757fb Reviewed-on: https://go-review.googlesource.com/c/tools/+/631778 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Alan Donovan <[email protected]>

adonovan · 2024-12-10T17:40:36Z

This stack 9nLJcw was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.4 linux/amd64 vscode (4)

adonovan · 2024-12-10T17:41:17Z

The latest stack indicates a refinement: a local type without type args or params, most likely a local named type.

adonovan · 2025-02-11T21:04:04Z

This stack B-EmyA was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.4 linux/amd64 vscode (1)

adonovan · 2025-02-20T17:07:58Z

This stack re0xQw was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache/methodsets.(*indexBuilder).build.func2.1:=236
golang.org/x/tools/gopls/internal/cache/methodsets.(*indexBuilder).build.func2:+32
golang.org/x/tools/gopls/internal/cache/methodsets.methodSetInfo:+19
golang.org/x/tools/gopls/internal/cache/methodsets.(*indexBuilder).build:+59
golang.org/x/tools/gopls/internal/cache/methodsets.NewIndex:=83
golang.org/x/tools/gopls/internal/cache.(*syntaxPackage).methodsets.func1:+1
sync.(*Once).doSlow:+5
sync.(*Once).Do:=69
golang.org/x/tools/gopls/internal/cache.(*syntaxPackage).methodsets:+1
golang.org/x/tools/gopls/internal/cache.storePackageResults:+3
runtime.goexit:+0

golang.org/x/tools/[email protected] go1.24.0 darwin/arm64 vscode-insiders (2)

findleyr · 2025-02-20T17:46:48Z

@jacksoom why did you close this?

adonovan · 2025-02-27T16:21:22Z

This stack VFXJYg was reported by telemetry:

gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache/methodsets.(*indexBuilder).build.func2.1:=252
golang.org/x/tools/gopls/internal/cache/methodsets.(*indexBuilder).build.func2:+32
golang.org/x/tools/gopls/internal/cache/methodsets.methodSetInfo:+22
golang.org/x/tools/gopls/internal/cache/methodsets.(*indexBuilder).build:+59
golang.org/x/tools/gopls/internal/cache/methodsets.NewIndex:=82
golang.org/x/tools/gopls/internal/cache.(*syntaxPackage).methodsets.func1:+1
sync.(*Once).doSlow:+5
sync.(*Once).Do:=69
golang.org/x/tools/gopls/internal/cache.(*syntaxPackage).methodsets:+1
golang.org/x/tools/gopls/internal/cache.storePackageResults:+3
runtime.goexit:+0

golang.org/x/tools/[email protected] go1.24.0 darwin/arm64 vscode-insiders (7)

adonovan · 2025-03-20T16:12:11Z

This stack MDN9RQ was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.2 darwin/amd64 vscode (1)

This stack yO6-PA was reported by telemetry:

golang.org/x/tools/[email protected] go1.23.7 darwin/amd64 vscode (1)

jacksoom closed this as completed Nov 16, 2024

jacksoom reopened this Nov 17, 2024

findleyr changed the title ~~gopls: automated issue report (crash)~~ x/tools/gopls: panic "can't find path for func" Nov 18, 2024

findleyr transferred this issue from golang/vscode-go Nov 18, 2024

findleyr added this to the gopls/v0.17.0 milestone Nov 18, 2024

gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 18, 2024

adonovan changed the title ~~x/tools/gopls: panic "can't find path for func"~~ x/tools/gopls/internal/cache/methodsets: "can't find path for func" panic in indexBuilder.build (no object path for method) Nov 18, 2024

findleyr assigned findleyr and unassigned findleyr Nov 19, 2024

adonovan added the gopls/telemetry-wins label Nov 19, 2024

findleyr assigned adonovan Nov 21, 2024

findleyr assigned findleyr and unassigned adonovan Nov 25, 2024

findleyr modified the milestones: gopls/v0.17.0, gopls/v0.18.0 Nov 26, 2024

findleyr modified the milestones: gopls/v0.18.0, gopls/v0.19.0 Feb 11, 2025

adonovan changed the title ~~x/tools/gopls/internal/cache/methodsets: "can't find path for func" panic in indexBuilder.build (no object path for method)~~ x/tools/gopls/internal/cache/methodsets: "missing object path for %s" bug in indexBuilder.build Feb 11, 2025

jacksoom closed this as completed Feb 20, 2025

findleyr reopened this Feb 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls/internal/cache/methodsets: "missing object path for %s" bug in indexBuilder.build #70418

x/tools/gopls/internal/cache/methodsets: "missing object path for %s" bug in indexBuilder.build #70418

jacksoom commented Nov 16, 2024 •

edited by adonovan

Loading

jacksoom commented Nov 17, 2024

jacksoom commented Nov 17, 2024

jacksoom commented Nov 17, 2024

jacksoom commented Nov 17, 2024

findleyr commented Nov 18, 2024

findleyr commented Nov 18, 2024 •

edited by adonovan

Loading

findleyr commented Nov 18, 2024 •

edited by adonovan

Loading

adonovan commented Nov 18, 2024

adonovan commented Nov 19, 2024

adonovan commented Nov 21, 2024 •

edited

Loading

gopherbot commented Nov 25, 2024

adonovan commented Dec 10, 2024

adonovan commented Dec 10, 2024

adonovan commented Feb 11, 2025

adonovan commented Feb 20, 2025

findleyr commented Feb 20, 2025

adonovan commented Feb 27, 2025

adonovan commented Mar 20, 2025

x/tools/gopls/internal/cache/methodsets: "missing object path for %s" bug in indexBuilder.build #70418

x/tools/gopls/internal/cache/methodsets: "missing object path for %s" bug in indexBuilder.build #70418

Comments

jacksoom commented Nov 16, 2024 • edited by adonovan Loading

jacksoom commented Nov 17, 2024

jacksoom commented Nov 17, 2024

jacksoom commented Nov 17, 2024

jacksoom commented Nov 17, 2024

findleyr commented Nov 18, 2024

findleyr commented Nov 18, 2024 • edited by adonovan Loading

findleyr commented Nov 18, 2024 • edited by adonovan Loading

adonovan commented Nov 18, 2024

adonovan commented Nov 19, 2024

adonovan commented Nov 21, 2024 • edited Loading

gopherbot commented Nov 25, 2024

adonovan commented Dec 10, 2024

adonovan commented Dec 10, 2024

adonovan commented Feb 11, 2025

adonovan commented Feb 20, 2025

findleyr commented Feb 20, 2025

adonovan commented Feb 27, 2025

adonovan commented Mar 20, 2025

jacksoom commented Nov 16, 2024 •

edited by adonovan

Loading

findleyr commented Nov 18, 2024 •

edited by adonovan

Loading

findleyr commented Nov 18, 2024 •

edited by adonovan

Loading

adonovan commented Nov 21, 2024 •

edited

Loading