Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: redirect to known alternative spelling for https://pkg.go.dev/github.com/ibm/sarama #71256

Closed
dnwe opened this issue Jan 13, 2025 · 4 comments

Comments

@dnwe
Copy link

dnwe commented Jan 13, 2025

What is the path of the package that you would like to have removed?

https://pkg.go.dev/github.com/ibm/sarama (case sensitive)

Are you the owner of this package?

Yes I am the owner of this package under the IBM org.

What is the reason that you could not retract this package instead?

pkgsite seems to accidentally have an invalid (and outdated) lowercase entry at https://pkg.go.dev/github.com/ibm/sarama whereas the correct module path is https://pkg.go.dev/github.com/IBM/sarama which is correct an up-to-date.

Please can you remove the invalid lowercase entry at https://pkg.go.dev/github.com/ibm/sarama (whilst retaining/keeping the uppercase IBM entry at https://pkg.go.dev/github.com/IBM/sarama)

@dnwe dnwe added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Jan 13, 2025
@gopherbot gopherbot added this to the Unreleased milestone Jan 13, 2025
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@dnwe
Copy link
Author

dnwe commented Jan 13, 2025

Ah yes, looks like has been handled here so adding a similar map entry to knownAlternatives of:

	"github.com/ibm/sarama":                        "github.com/IBM/sarama",

should fix this issue

@findleyr
Copy link
Member

@dnwe thanks for investigating. If you would like to fix this, could you please send a CL? Thanks.

@findleyr findleyr added help wanted and removed pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package labels Jan 15, 2025
@findleyr findleyr changed the title x/pkgsite: package removal request for (case sensitive) https://pkg.go.dev/github.com/ibm/sarama x/pkgsite: redirect to known alternative spelling for https://pkg.go.dev/github.com/ibm/sarama Jan 15, 2025
dnwe added a commit to dnwe/pkgsite that referenced this issue Jan 15, 2025
Similar to golang/go#52192 we need to add lowercase ibm/sarama to the
knownAlternatives map to ensure the canonical uppercase variant (as
defined in go.mod) is chosen in preference.

Fixes golang/go#71256

Signed-off-by: Dominic Evans <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/642600 mentions this issue: internal/fetch: add correct canonical path for IBM/sarama

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants