Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/fetch: add correct canonical path for IBM/sarama #107

Closed
wants to merge 1 commit into from

Conversation

dnwe
Copy link
Contributor

@dnwe dnwe commented Jan 15, 2025

Similar to golang/go#52192 we need to add lowercase ibm/sarama to the
knownAlternatives map to ensure the canonical uppercase variant
(asdefined in go.mod) is chosen in preference.

Fixes golang/go#71256

Similar to golang/go#52192 we need to add lowercase ibm/sarama to the
knownAlternatives map to ensure the canonical uppercase variant (as
defined in go.mod) is chosen in preference.

Fixes golang/go#71256

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@gopherbot
Copy link
Contributor

This PR (HEAD: eeafa01) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/642600.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-01-16T18:59:39Z","revision":"9c3db2b4d83241602cc26f09dbea1aa972edd82a"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1:

Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/f4b13cd5-d8ba-4108-925d-79b58e4109ba


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/f4b13cd5-d8ba-4108-925d-79b58e4109ba


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/f4b13cd5-d8ba-4108-925d-79b58e4109ba


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dominic Evans:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dominic Evans:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dominic Evans:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 2: Code-Review+2 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-01-17T14:18:03Z","revision":"64487dd0853ed51972e47727862f156744d726fb"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 2:

Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/e365f4b0-2e71-402d-9137-8472f7df30d8


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/e365f4b0-2e71-402d-9137-8472f7df30d8


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/642600.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 17, 2025
Similar to golang/go#52192 we need to add lowercase ibm/sarama to the
knownAlternatives map to ensure the canonical uppercase variant
(asdefined in go.mod) is chosen in preference.

Fixes golang/go#71256

Change-Id: I190dafa0495adae304f25a5b194e74aa23f2079e
GitHub-Last-Rev: eeafa01
GitHub-Pull-Request: #107
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/642600
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/642600 has been merged.

@gopherbot gopherbot closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/pkgsite: redirect to known alternative spelling for https://pkg.go.dev/github.com/ibm/sarama
2 participants