-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/fetch: add correct canonical path for IBM/sarama #107
Conversation
Similar to golang/go#52192 we need to add lowercase ibm/sarama to the knownAlternatives map to ensure the canonical uppercase variant (as defined in go.mod) is chosen in preference. Fixes golang/go#71256 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
This PR (HEAD: eeafa01) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/642600. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Robert Findley: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-01-16T18:59:39Z","revision":"9c3db2b4d83241602cc26f09dbea1aa972edd82a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from kokoro: Patch Set 1: Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from kokoro: Patch Set 1: Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Robert Findley: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from kokoro: Patch Set 1: kokoro-CI+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Alan Donovan: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Robert Findley: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Dominic Evans: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Dominic Evans: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Dominic Evans: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Robert Findley: Patch Set 2: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-01-17T14:18:03Z","revision":"64487dd0853ed51972e47727862f156744d726fb"} Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from kokoro: Patch Set 2: Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from kokoro: Patch Set 2: Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Robert Findley: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/642600. |
Similar to golang/go#52192 we need to add lowercase ibm/sarama to the knownAlternatives map to ensure the canonical uppercase variant (asdefined in go.mod) is chosen in preference. Fixes golang/go#71256 Change-Id: I190dafa0495adae304f25a5b194e74aa23f2079e GitHub-Last-Rev: eeafa01 GitHub-Pull-Request: #107 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/642600 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Robert Findley <rfindley@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
This PR is being closed because golang.org/cl/642600 has been merged. |
Similar to golang/go#52192 we need to add lowercase ibm/sarama to the
knownAlternatives map to ensure the canonical uppercase variant
(asdefined in go.mod) is chosen in preference.
Fixes golang/go#71256