Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/cmd: go/types data race causes TestImplementations failures #72082

Open
gopherbot opened this issue Mar 3, 2025 · 31 comments
Open

x/tools/gopls/internal/cmd: go/types data race causes TestImplementations failures #72082

gopherbot opened this issue Mar 3, 2025 · 31 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.19.0

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c006fcca6a by goroutine 4731:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x86
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (16.02s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-03 14:37 x_tools-gotip-freebsd-amd64-race tools@0efa5e51 go@0312e31e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c006fcca6a by goroutine 4731:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo736394432/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x86
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (16.02s)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 3, 2025
@gopherbot gopherbot added this to the Unreleased milestone Mar 3, 2025
@adonovan
Copy link
Member

adonovan commented Mar 3, 2025

Dup of #71817 (types.CheckExpr mutates objects => data race)

@adonovan adonovan closed this as completed Mar 3, 2025
@gopherbot gopherbot reopened this Mar 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-03 20:04 x_tools-go1.23-linux-arm64-race tools@0ffdb82e release-branch.go1.23@e4772831 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00f47e52a by goroutine 6132:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1177258198/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1177258198/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (22.34s)

— watchflakes

@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Mar 3, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-04 19:48 x_tools-gotip-linux-arm64-race tools@d81d6fcc go@0cfc6414 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c01597816a by goroutine 4748:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x4c8
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0x94
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x40
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2229727998/gopls/internal/cache/analysis.go:906 +0xbc
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (12.07s)

— watchflakes

@adonovan adonovan changed the title x/tools/gopls/internal/cmd: TestImplementations failures x/tools/gopls/internal/cmd: go/types data race causes TestImplementations failures Mar 5, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-05 16:17 x_tools-go1.24-linux-arm64-race tools@07219402 release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00bdbe52a by goroutine 5022:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4111022109/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4111022109/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (16.57s)
2025-03-05 16:17 x_tools-gotip-linux-arm64-race tools@07219402 go@2c160414 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0137aa6a8 by goroutine 6005:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x520
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1360793670/gopls/internal/cache/analysis.go:605 +0x1dc
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1360793670/gopls/internal/cache/analysis.go:341 +0x430
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x70
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (17.85s)
2025-03-05 16:17 x_tools-gotip-linux-amd64-race tools@340f21a4 go@2c160414 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00e12596a by goroutine 5100:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x657
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2106427111/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2106427111/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x86
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (22.91s)
2025-03-05 16:48 x_tools-go1.24-windows-amd64-race tools@ece9e9ba release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\goroot\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\goroot\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c017b94708 by goroutine 5970:
          go/types.(*Selection).Type()
              C:/b/s/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo2870606075/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo2870606075/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (19.13s)
2025-03-05 18:38 x_tools-go1.24-linux-amd64-longtest-race tools@db6008cb release-branch.go1.24@e4119e9b x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0130f3c08 by goroutine 5506:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3405952524/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3405952524/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (43.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-05 19:59 x_tools-go1.23-linux-amd64-race tools@25a90bef release-branch.go1.23@45aade7f x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c009bcf968 by goroutine 4771:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo831806434/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo831806434/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (25.96s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-05 20:18 x_tools-go1.24-linux-arm64-race tools@6a5b66be release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00ee220aa by goroutine 5532:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3984249478/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3984249478/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (19.37s)

— watchflakes

@ansaba ansaba modified the milestones: Unreleased, gopls/v0.19.0 Mar 6, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-07 21:08 x_tools-go1.24-darwin-amd64-race tools@29f81e9d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00de5a8ea by goroutine 5633:
          go/types.(*Checker).ident()
              /Users/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3259244965/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3259244965/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (43.13s)
2025-03-07 21:08 x_tools-go1.24-linux-arm64-race tools@29f81e9d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00dc6130a by goroutine 2476:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0xac
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x40
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3655494404/gopls/internal/cache/analysis.go:906 +0xd0
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (7.37s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-08 17:41 x_tools-go1.24-windows-amd64-race tools@8fa586e1 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\goroot\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\goroot\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0110f2a68 by goroutine 3955:
          go/types.(*Selection).Type()
              C:/b/s/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo224832640/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo224832640/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (23.84s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-08 17:41 x_tools-go1.24-linux-amd64-race tools@8fa586e1 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c014dab78a by goroutine 3635:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3865301713/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (18.75s)
2025-03-10 11:26 x_tools-go1.24-linux-amd64-race tools@5a45ac2d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0095c9368 by goroutine 4825:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1914189388/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1914189388/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (23.73s)

— watchflakes

@adonovan
Copy link
Member

Dup of #72122. Fixed by https://go.dev/cl/655437.

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Mar 11, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-10 21:05 x_tools-go1.23-linux-amd64-race tools@cc7d6983 release-branch.go1.23@45aade7f x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00f326348 by goroutine 5703:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1006219545/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1006219545/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (27.82s)

— watchflakes

@gopherbot gopherbot reopened this Mar 12, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-11 21:41 x_tools-go1.23-darwin-amd64-race tools@381d68d8 release-branch.go1.23@45aade7f x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00d3a088a by goroutine 4627:
          go/types.(*Checker).ident()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3282045828/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo3282045828/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (68.57s)
2025-03-11 21:41 x_tools-go1.24-linux-amd64-race tools@381d68d8 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00b332caa by goroutine 4775:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1647068026/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (24.71s)

— watchflakes

@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Mar 12, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-12 00:09 x_tools-go1.24-linux-arm64-race tools@bf702957 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0132ddf08 by goroutine 2939:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x548
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo731528329/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo731528329/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (11.25s)

— watchflakes

@adonovan
Copy link
Member

@findleyr I think we need to backport the fix to #71817 to the go1.24 release branch.

@findleyr
Copy link
Member

I created the backport in #72826, but now that I think about it, I'm not sure. The fix is nontrivial, has potential performance implications, and we've been living with the current race for years.

Shall we just skip this test on 1.24?

@adonovan
Copy link
Member

AFAICT The cause is unrelated to this particular test: the rangeint modernizer pass calls types.CheckExpr, and gopls runs analysis asynchronously, so almost any test might exhibit the same race as this one. (I don't understand why it appears to have such affinity for TestImplementations.)

@findleyr
Copy link
Member

Aha, sorry I thought I recalled you saying it was a new test.

In that case, yes I do think we should backport.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-12 20:41 x_tools-go1.24-linux-amd64-race tools@e59d6c5d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c009fe070a by goroutine 5020:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1326253131/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1326253131/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (23.15s)
2025-03-12 20:41 x_tools-go1.24-linux-arm64-race tools@e59d6c5d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c013c990ca by goroutine 2899:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo337136338/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo337136338/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (10.29s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-13 23:31 x_tools-go1.23-linux-amd64-race tools@dcc4b8a1 release-branch.go1.23@45aade7f x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c0112f45ea by goroutine 5526:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2183531154/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2183531154/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (25.82s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-17 14:05 x_tools-go1.23-darwin-amd64-race tools@e06efb48 release-branch.go1.23@45aade7f x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00c6b60aa by goroutine 3993:
          go/types.(*Checker).ident()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo474506512/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (36.63s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-17 21:37 x_tools-go1.24-darwin-amd64-race tools@95eb16e6 release-branch.go1.24@fd29397d x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00ecd3368 by goroutine 5917:
          go/types.(*Selection).Type()
              /Users/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo1881804224/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo1881804224/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (43.01s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-18 18:40 x_tools-go1.23-linux-amd64-longtest-race tools@7042bab9 release-branch.go1.23@15e01a2e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0168f9ae8 by goroutine 3979:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3551760871/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3551760871/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (32.66s)
2025-03-18 18:40 x_tools-go1.24-darwin-amd64-race tools@7042bab9 release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00fb5a52a by goroutine 5778:
          go/types.(*Checker).ident()
              /Users/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo4189088891/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo4189088891/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (42.65s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-19 02:33 x_tools-go1.24-linux-amd64-race tools@a70d348b release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c01487a168 by goroutine 3825:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2356267349/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2356267349/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (17.69s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-19 02:33 x_tools-go1.23-darwin-amd64-race tools@a70d348b release-branch.go1.23@15e01a2e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00c42b54a by goroutine 5618:
          go/types.(*Checker).ident()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo852032249/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /Users/swarming/.swarming/w/ir/x/w/targetrepo852032249/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /Users/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (49.12s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-19 20:43 x_tools-go1.24-linux-arm64-race tools@58e40aec release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00c834c48 by goroutine 4688:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x548
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3669591130/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3669591130/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (16.18s)
2025-03-20 14:07 x_tools-go1.24-linux-arm64-race tools@3a64d744 release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00d0d2eea by goroutine 5329:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3770978860/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3770978860/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (19.24s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-20 18:17 x_tools-go1.23-linux-amd64-race tools@9b2264a6 release-branch.go1.23@15e01a2e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00ab125ea by goroutine 3902:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/typexpr.go:122 +0xc56
...
          sync.(*Once).doSlow()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/sync/once.go:78 +0xe1
          sync.(*Once).Do()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/sync/once.go:69 +0x44
          golang.org/x/tools/gopls/internal/cache.execActions.func1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4230533665/gopls/internal/cache/analysis.go:906 +0x104
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (23.87s)
2025-03-20 18:17 x_tools-go1.24-linux-arm64-race tools@9b2264a6 release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00c54b0c8 by goroutine 5603:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x548
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo681868954/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo681868954/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (19.05s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-21 14:54 x_tools-go1.24-linux-amd64-race tools@c2768b73 release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c011da6408 by goroutine 5928:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1525659869/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1525659869/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (22.82s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-21 18:23 x_tools-go1.23-linux-amd64-race tools@084551fb release-branch.go1.23@15e01a2e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00ef7b8aa by goroutine 5230:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3879744314/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo3879744314/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (24.54s)
2025-03-21 18:59 x_tools-go1.23-windows-amd64-race tools@20f88906 release-branch.go1.23@15e01a2e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<<C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\[email protected]\src\fmt\print.go:64:2-8
        C:\b\s\w\ir\x\w\gopath\pkg\mod\golang.org\[email protected]\src\runtime\error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0114f89a8 by goroutine 3826:
          go/types.(*Selection).Type()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              C:/b/s/w/ir/x/w/targetrepo4157340860/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              C:/b/s/w/ir/x/w/targetrepo4157340860/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              C:/b/s/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (23.35s)
2025-03-21 18:59 x_tools-go1.24-linux-amd64-longtest-race tools@20f88906 release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00fa5bea8 by goroutine 5324:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2286359434/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2286359434/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (40.97s)
2025-03-21 18:59 x_tools-go1.24-linux-arm64-race tools@20f88906 release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c0117669aa by goroutine 4372:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/typexpr.go:122 +0x97c
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1073657693/gopls/internal/cache/analysis.go:605 +0x1e0
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo1073657693/gopls/internal/cache/analysis.go:341 +0x46c
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x7c
        ==================
        Found 2 data race(s)
        >>)
--- FAIL: TestImplementations (15.63s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-21 19:10 x_tools-go1.23-linux-amd64-race tools@ec542a7d release-branch.go1.23@15e01a2e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00b78e82a by goroutine 4894:
          go/types.(*Checker).ident()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/typexpr.go:122 +0xc56
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4058127683/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo4058127683/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (25.86s)
2025-03-21 19:10 x_tools-go1.24-linux-amd64-race tools@ec542a7d release-branch.go1.24@ac1f5aa3 x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/goroot/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c010280e28 by goroutine 5440:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/goroot/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo929418373/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo929418373/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (24.19s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestImplementations"
2025-03-24 13:47 x_tools-go1.23-linux-amd64-longtest-race tools@bf12eb7e release-branch.go1.23@15e01a2e x/tools/gopls/internal/cmd.TestImplementations (log) 
=== RUN   TestImplementations
=== PAUSE TestImplementations
=== CONT  TestImplementations
    integration_test.go:528: gopls implementation a.go:4:10: exited with code 66, want success: true (gopls implementation a.go:4:10: exit=66 stdout=<</home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/fmt/print.go:64:2-8
        /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/runtime/error.go:212:2-8
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00e26a1c8 by goroutine 4751:
          go/types.(*Selection).Type()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/[email protected]/src/go/types/selection.go:101 +0x698
...
          golang.org/x/tools/gopls/internal/cache.(*analysisNode).runCached()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2724563612/gopls/internal/cache/analysis.go:605 +0x2a8
          golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze.func6.1()
              /home/swarming/.swarming/w/ir/x/w/targetrepo2724563612/gopls/internal/cache/analysis.go:341 +0x649
          golang.org/x/sync/errgroup.(*Group).Go.func1()
              /home/swarming/.swarming/w/ir/x/w/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:78 +0x91
        ==================
        Found 1 data race(s)
        >>)
--- FAIL: TestImplementations (40.00s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Active
Milestone
gopls/v0.19.0
Development

No branches or pull requests
4 participants
@ansaba @adonovan @gopherbot @findleyr