Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration: tests failing on openbsd/amd64 due to stalling and timing out #72145

Open
dmitshur opened this issue Mar 6, 2025 · 6 comments
Open

x/tools/gopls/internal/test/integration: tests failing on openbsd/amd64 due to stalling and timing out #72145

dmitshur opened this issue Mar 6, 2025 · 6 comments
Labels
arch-amd64 Builders x/build issues (builders, bots, dashboards) gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.19.0

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 6, 2025 •
edited
Loading

Consider the following recent x/tools builds from a newer openbsd/amd64 builder with OpenBSD 7.6:

Comparing them with the recent x/tools from an older openbsd/amd64 builder with OpenBSD 7.2:

There are approximately 10 tests that have started to fail quite consistently on the new openbsd/amd64 builder with OpenBSD 7.6. In contrast, the older OpenBSD 7.2 builder had both passing results and flaky failures, especially those tracked in issue #54461.

This might be a problem with OpenBSD 7.6, something about the builder image, or something in x/tools/gopls tests itself.

The builder is currently marked with a known issue #69823, and finding some resolution to this (potentially skipping the affected tests if appropriate) is needed to be able to remove that known issue.

CC @golang/openbsd, @golang/tools-team.
@dmitshur dmitshur added arch-amd64 NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD Tools This label describes issues relating to any tools in the x/tools repository. labels Mar 6, 2025
@dmitshur dmitshur added this to the Unreleased milestone Mar 6, 2025
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Mar 6, 2025
@dmitshur dmitshur mentioned this issue Mar 6, 2025
Closed
@gabyhelp
Copy link

gabyhelp commented Mar 6, 2025

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp added the Builders x/build issues (builders, bots, dashboards) label Mar 6, 2025
@adonovan
Copy link
Member

The "directory not empty" failures have been a persistent problem on openbsd for a long time, but they were flakes. If they are now deterministic that is good news as we may have a hope of debugging them.

@h9jiang h9jiang modified the milestones: Unreleased, Backlog, gopls/v0.19.0 Mar 13, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/658015 mentions this issue: gopls/internal/test/integration: skip x_tools-gotip-openbsd-amd64_7.6

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/658016 mentions this issue: main.star: don't hide openbsd-amd64_7.6 from presubmit

gopherbot pushed a commit to golang/build that referenced this issue Mar 17, 2025
@dmitshur @gopherbot
main.star: don't hide openbsd-amd64_7.6 from presubmit
cf1c70e 
Otherwise it's not possible to test that a fix (or skip) for the known
issue works, as I ran into in CL 658015:

	Failed to compute tryjob requirement. Reason:

	builder "golang/try/x_tools-gotip-openbsd-amd64_7.6" is included but not defined in the LUCI project

For golang/go#72145.

Change-Id: I4e447a8dadf2ad3a1def6b9caab9140bf08b61c4
Reviewed-on: https://go-review.googlesource.com/c/build/+/658016
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: David Chase <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@adonovan
Copy link
Member

adonovan commented Mar 17, 2025 •
edited by gabyhelp
Loading

The last several weeks of flakes on #54461 have all been due to openbsd. Will submitting CL 658016 pacify them?

[Updated: my first draft said #68087 by mistake.]

@dmitshur
Copy link
Contributor Author

dmitshur commented Mar 17, 2025 •
edited
Loading

The flakes in #54461 seem to happen on OpenBSD 7.2 builders only.
CL 654676 replaces the previous OpenBSD 7.2 builders with the new 7.6 ones, so those those will go away.

The OpenBSD 7.6 builders seem to be triggering stalls much more reproducibly, as tracked in this issue.
CL 658015 adds a skip for the known issue so it can be investigated without undue time pressure.

@dmitshur dmitshur changed the title x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 after OpenBSD 7.2 → 7.6 upgrade x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 due to stalling and timing out Mar 17, 2025
@dmitshur dmitshur changed the title x/tools/gopls/internal/test/integration: 10 tests failing on openbsd/amd64 due to stalling and timing out x/tools/gopls/internal/test/integration: tests failing on openbsd/amd64 due to stalling and timing out Mar 17, 2025
gopherbot pushed a commit to golang/tools that referenced this issue Mar 17, 2025
@dmitshur @gopherbot
gopls/internal/test/integration: skip x_tools-gotip-openbsd-amd64 (7.6)
95eb16e 
The new openbsd/amd64 7.6 builder is generally working well everywhere
but this one place. Add a skip for now to buy time to investigate this
issue.

Note that the previous openbsd/amd64 7.2 builder was also running into
problems with these tests, as tracked in go.dev/issue/54461, though it
wasn't happening as consistently as it is now.

For golang/go#72145.
For golang/go#54461.

Change-Id: I6dd34fcdcca99c90282f0b9119936efa6bebf458
Cq-Include-Trybots: luci.golang.try:x_tools-gotip-openbsd-amd64
Reviewed-on: https://go-review.googlesource.com/c/tools/+/658015
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-amd64 Builders x/build issues (builders, bots, dashboards) gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.19.0
Development

No branches or pull requests
5 participants
@dmitshur @adonovan @gopherbot @h9jiang @gabyhelp