-
Notifications
You must be signed in to change notification settings - Fork 18.3k
encoding/xml: add omitzero option #74579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: de00bf1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/687397. Important tips:
|
Message from Jes Cok: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-11T12:25:24Z","revision":"a24e0abb4ba0a71ecc9b02c4e02a6cc590301a70"} Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Jes Cok: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
de00bf1
to
79e5ea4
Compare
This PR (HEAD: 79e5ea4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/687397. Important tips:
|
Message from Jes Cok: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-25T12:12:29Z","revision":"f87b7a6e48ab063cf970162ae2193695fb24f24a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Jes Cok: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Fixes golang#69857 Change-Id: Ib224b85aa96dad89ead944aa9f65e9e34d9bba5e
79e5ea4
to
9ae2149
Compare
This PR (HEAD: 9ae2149) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/687397. Important tips:
|
Message from Jes Cok: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-26T01:46:26Z","revision":"f55689de5ba992c631404bd6e7036ae0d207eff4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Jes Cok: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/687397. |
Related to CL 615676.
For faster implementation, almost all the code was copied
from that CL.
Fixes #69857