-
Notifications
You must be signed in to change notification settings - Fork 18.3k
crypto/elliptic: change a variable name that have the same name as keywords #74736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 70c8054) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690135. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from 叶万标: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from qiu laidongfeng2: Patch Set 2: Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-25T14:19:12Z","revision":"41f7fb666f826bd2b5a1bb278130ebceed490300"} Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from qiu laidongfeng2: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from Roland Shoemaker: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
Message from Michael Knyszek: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/690135. |
…ywords Change the variable name from byte to b, and use range over int to simplify the loop. Change-Id: I8855053c26ce798311f12505cd5edf21d7caf1f5 GitHub-Last-Rev: 70c8054 GitHub-Pull-Request: #74736 Reviewed-on: https://go-review.googlesource.com/c/go/+/690135 Reviewed-by: qiu laidongfeng <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>
This PR is being closed because golang.org/cl/690135 has been merged. |
Change the variable name from byte to b, and use range over int to
simplify the loop.