-
Notifications
You must be signed in to change notification settings - Fork 18.4k
debug/elf: make check for empty symbol section consistent for 64-bit and 32-bit binaries #75334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: d7ca142) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/702195. Important tips:
|
d7ca142
to
5b77732
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/702195. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/702195. |
This PR (HEAD: 5b77732) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/702195. Important tips:
|
5b77732
to
c9e41f5
Compare
Message from Aditya Sirish A Yelgundhalli: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/702195. |
This PR (HEAD: c9e41f5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/702195. Important tips:
|
Message from Florian Lehner: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/702195. |
Message from Aditya Sirish A Yelgundhalli: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/702195. |
Message from Ian Lance Taylor: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/702195. |
…and 32-bit binaries The check for whether a binary's symbols section is empty is inconsistent across the 32-bit and 64-bit flows.
c9e41f5
to
f264915
Compare
This PR (HEAD: f264915) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/702195. Important tips:
|
The check for whether a binary's symbols section is empty is
inconsistent across the 32-bit and 64-bit flows.