archive/tar: reset Size to 0 for header-only types in WriteHeader #77048

heathdutton · 2026-01-01T22:04:18Z

When writing a header-only type (TypeLink, TypeSymlink, TypeChar,
TypeBlock, TypeDir, TypeFifo) with a non-zero Size, the resulting
archive is corrupt because the header claims data follows but none
is written.

Reset Size to 0 for header-only types before encoding the header.

Fixes #76468

When writing a header-only type (TypeLink, TypeSymlink, TypeChar, TypeBlock, TypeDir, TypeFifo) with a non-zero Size, the resulting archive is corrupt because the header claims data follows but none is written. Reset Size to 0 for header-only types before encoding the header. Fixes golang#76468

gopherbot · 2026-01-01T22:09:12Z

This PR (HEAD: 0618260) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/733600.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-01-04T12:19:36Z

Message from qiu laidongfeng:

Patch Set 1: Commit-Queue+1