Skip to content

Comments

runtime: use fast path when channel has been closed and empty#77526

Open
delichik wants to merge 1 commit intogolang:masterfrom
delichik:master
Open

runtime: use fast path when channel has been closed and empty#77526
delichik wants to merge 1 commit intogolang:masterfrom
delichik:master

Conversation

@delichik
Copy link

update #77522

Check channel emptiness in recv regardless of blocking mode. If the channel is empty and already closed, recheck emptiness and allow recv to return immediately without entering the lock.

This improves receive performance on closed channels and also benefits cgocallback performance. The side effect is that normal blocking receives perform one additional empty() check, but this cost is negligible compared to acquiring the lock.

@gopherbot
Copy link
Contributor

This PR (HEAD: 812beeb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/743781.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-02-10T14:50:01Z","revision":"9781d0e1ceeff3dd894dfe296d3078d5460f876f"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1: -Commit-Queue

(Posted by golang-scoped@luci-project-accounts.iam.gserviceaccount.com on behalf of jorropo.pgm@gmail.com)


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Pratt:

Patch Set 1: Code-Review+1 Commit-Queue+1

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-02-24T00:00:03Z","revision":"9781d0e1ceeff3dd894dfe296d3078d5460f876f"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Pratt:

Patch Set 1: -Commit-Queue

(Performed by golang-scoped@luci-project-accounts.iam.gserviceaccount.com on behalf of mpratt@google.com)


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/743781.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants