all: test: remove unneeded loop variables by ariel-anieli · Pull Request #77694 · golang/go

ariel-anieli · 2026-02-18T23:11:23Z

This CL follows from the abandoned CL 722961.

Alan Donovan asked if modernize would catch these changes; it does in part.

Here is how modernize was used:

Build the Go compiler from latest master
Clone x/tools and build modernize with the newest compiler
Then, do:

PATH=PATH_TO_BIN:$PATH go list ./... | xargs env PATH=PATH_TO_BIN:$PATH GOMOD=off MODERNIZE -forvar -fix -test -debug fpstv
For assurance, move into a package directory (i.e, cmd), and redo Step 3.

From the obtained result, it seems modernize did not remove the loop variable when:

the range notation was not used
the loop variable was not directly under the for directive.

Which does happens here:

# git ls-files | xargs -I {} perl -nE 'print "$ARGV:$.:$_" if /\s+(\w+) := \1$/' {} | grep _test
[...]
cmd/compile/internal/types2/api_test.go:2423:                   i := i
md/go/internal/modload/query_test.go:182:              tt := tt
md/go/internal/web/url_test.go:17:             tc := tc
cmd/go/internal/web/url_test.go:49:             tc := tc
cmd/internal/par/queue_test.go:54:              i := i
runtime/syscall_windows_test.go:781:            arglen := arglen

Link: https://go-review.googlesource.com/c/go/+/722961/comments/e8d47866_fc399fa1
Co-authored-by: Plamerdi Makela plamerdi447@gmail.com
Fixes #76411

gopherbot · 2026-02-18T23:31:23Z

This PR (HEAD: f7c955d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/746502.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-02-18T23:40:35Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-18T23:49:01Z

Message from Ariel Otilibili Anieli:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-23T18:43:22Z

Message from Alan Donovan:

Patch Set 2: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-23T18:52:21Z

Message from Jorropo:

Patch Set 2: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

This CL follows from the abandoned CL 722961. Alan Donovan asked if modernize would catch these changes; it does in part. Here is how modernize was used: 1. Build the Go compiler from latest master 2. Clone x/tools and build modernize with the newest compiler 3. Then, do: PATH=PATH_TO_BIN:$PATH go list ./... | xargs env PATH=PATH_TO_BIN:$PATH GOMOD=off MODERNIZE -forvar -fix -test -debug fpstv 4. For assurance, move into a package directory (i.e, cmd), and redo Step 3. From the obtained result, it seems modernize did not remove the loop variable when: - the range notation was not used - the loop variable was not directly under the for directive. Which does happens here: # git ls-files | xargs -I {} perl -nE 'print "$ARGV:$.:$_" if /\s+(\w+) := \1$/' {} | grep _test [...] cmd/compile/internal/types2/api_test.go:2423: i := i md/go/internal/modload/query_test.go:182: tt := tt md/go/internal/web/url_test.go:17: tc := tc cmd/go/internal/web/url_test.go:49: tc := tc cmd/internal/par/queue_test.go:54: i := i runtime/syscall_windows_test.go:781: arglen := arglen Fixes golang#76411. Link: https://go-review.googlesource.com/c/go/+/722961/comments/e8d47866_fc399fa1 Co-authored-by: Plamerdi Makela <plamerdi447@gmail.com>

gopherbot · 2026-02-24T01:22:42Z

This PR (HEAD: 77c3e11) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/746502.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-02-24T01:31:15Z

Message from Ariel Otilibili Anieli:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T01:39:15Z

Message from Alan Donovan:

Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T01:39:16Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-02-24T01:27:29Z","revision":"7d4f8be5469fd932cde049312a9f2a967e4eb894"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T01:39:17Z

Message from Alan Donovan:

Patch Set 3: -Commit-Queue

(Performed by golang-scoped@luci-project-accounts.iam.gserviceaccount.com on behalf of adonovan@google.com)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T01:39:17Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/x_debug-gotip-linux-amd64. Summary (view all results):

go on master (change 746502) / debug on master (commit 294b3ab)

To reproduce, try gomote repro 8689025619902132097.

Additional links for debugging:

make.bash output

golang/try/x_tools-gotip-linux-amd64. Summary (view all results):

go on master (change 746502) / tools on master (commit c48686b)

To reproduce, try gomote repro 8689025619902132081.

Additional links for debugging:

make.bash output

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T01:39:18Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T01:47:40Z

Message from Ariel Otilibili Anieli:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T01:55:33Z

Message from Alan Donovan:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T01:55:34Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-02-24T01:47:51Z","revision":"0836553c6a25aeafeafbc56603e2935a3a1bd648"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T02:04:16Z

Message from Ariel Otilibili Anieli:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T02:21:24Z

Message from Alan Donovan:

Patch Set 4: -Commit-Queue

(Performed by golang-scoped@luci-project-accounts.iam.gserviceaccount.com on behalf of adonovan@google.com)

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T02:21:24Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-boringcrypto has failed with summary (view all results):

go on master (change 746502)

To reproduce, try gomote repro 8689024338119324929.

Additional links for debugging:

go tool dist test -json output [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-24T02:21:25Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/746502.
After addressing review feedback, remember to publish your drafts!

ariel-anieli force-pushed the modernize-forvar-issue-76411 branch from f7c955d to 77c3e11 Compare February 24, 2026 01:18

Comments

Conversation

ariel-anieli commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Feb 18, 2026

Uh oh!

gopherbot commented Feb 18, 2026

Uh oh!

gopherbot commented Feb 18, 2026

Uh oh!

gopherbot commented Feb 23, 2026

Uh oh!

gopherbot commented Feb 23, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

gopherbot commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ariel-anieli commented Feb 18, 2026 •

edited

Loading