testing: fix construction of the testing artifacts path#77778
testing: fix construction of the testing artifacts path#77778ansel1 wants to merge 1 commit intogolang:masterfrom
Conversation
|
This PR (HEAD: a55a229) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/748581. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
|
Message from Russ Egan: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
|
Message from Damien Neil: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-02-24T23:57:06Z","revision":"89aecdd3d02b7e27481ac50e3e9d4c6f0dc7fa0f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
|
Message from Damien Neil: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
|
Message from Damien Neil: Patch Set 1: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5305>) Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
|
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64_avx512 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
The existing implementation constructs a path which starts with a forward slash, which is then immediately rejected by filepath.Localize() as invalid. This change simple removes the first forward slash. Fixes golang#77763
a55a229 to
9c39392
Compare
|
This PR (HEAD: 9c39392) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/748581. Important tips:
|
|
Message from Russ Egan: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/748581. |
The existing implementation constructs a path which starts with a forward
slash, which is then immediately rejected by filepath.Localize() as
invalid. This change simple removes the first forward slash.
Fixes #77763