-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scope specifies optional requested permissions for tokenRefresher #322
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLAs look good, thanks! |
This PR (HEAD: 8ddd60c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/135935 to see it. Tip: You can toggle comments from me using the |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Gerrit User 26193: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
This PR (HEAD: 429a0e6) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/135935 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 2: Run-TryBot+1 Which provider(s)? Can you elaborate in the commit message? Do any docs need updating? Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=bff90cd8 Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Gobot Gobot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
@bradfitz for example Ebay refresh token flow |
This PR (HEAD: 3501dcb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/135935 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=529449ff Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Gobot Gobot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
This PR (HEAD: 3e182ca) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/135935 to see it. Tip: You can toggle comments from me using the |
Message from Dave Dykstra: Patch Set 5: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Dave Dykstra: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
This PR very simply fixes a bug which prevents compliance with the Oauth 2.0 standard in RFC 6749 section 6 "Refreshing an Access Token" . Please merge this. |
Message from Dave Dykstra: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=bff90cd8 Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Go Bot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=529449ff Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Go Bot: Patch Set 4: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
I submitted #448 , which is almost a duplicate of this (minor formatting difference). RFC: https://tools.ietf.org/html/rfc6749#section-6
This patch brings the go implementation within rfc6749 specification for sending refresh requests. Go documentation should _not_ need to be changed. Why it is useful: oauth2 allows the refresh request to specify a subset of the scopes available to the client. Allowing the client to receive an access token with less scopes. (intersection of the available scopes and the requested scopes). The new access token is "safer" to use because of limited permissions/scopes. https://www.oauth.com/oauth2-servers/access-tokens/refreshing-access-tokens/ has a good paragraph on it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 9059d14) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/135935 to see it. Tip: You can toggle comments from me using the |
Some OAuth providers require "scope" value with "refresh_token" grant type
This PR (HEAD: 23290a8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/135935 to see it. Tip: You can toggle comments from me using the |
Message from Dave Dykstra: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Are there any updates on this? This PR would actually resolve issues with refreshing tokens against Azure Active Directory we face right now. |
You might have a better chance if you commented on gerrit, although I tried it and it also didn't go anywhere. |
This PR (HEAD: 83feb76) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/135935 to see it. Tip: You can toggle comments from me using the |
Message from Vijay Thakorlal: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Message from Dmytro Tananayskiy: Patch Set 8: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/135935. |
Some OAuth providers require "scope" value with "refresh_token" grant type
Format the payload of your POST request with the following values:
Set grant_type to refresh_token.
Set refresh_token to the refresh token value returned from the authorization code grant request.
Set scope to the same URL-encoded list of scopes that you used in the original consent request.
https://developer.ebay.com/api-docs/static/oauth-refresh-token-request.html