-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable JWT for Box.com #390
base: master
Are you sure you want to change the base?
Conversation
Some JWT Authentication APIs require the ability to pass additional querystring parameters. For example Box.com API requires "client_id" and "client_secret" parameters to be set ([ref][1]). [1]: https://developer.box.com/docs/construct-jwt-claim-manually#section-4-request-access-token
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
More info [here][1]. [1]: https://box-content.readme.io/docs/oauth-20
9e1c13f
to
f444c3d
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: f444c3d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/185999 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/185999. |
This would be very useful for rclone as currently we implement our own JWT stuff for access to box.com. What is the status of this PR? |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/185999. |
f444c3d box: add box.com OAuth endpoint
More info here.
32e393c Enable passing of additional Querystring params when requesting token
Some JWT Authentication APIs require the ability to pass additional
querystring parameters. For example Box.com API requires "client_id" and
"client_secret" parameters to be set (ref).