Added Withings Health Mate OAuth2 endpoint

[emmaly]

Nokia acquired Withings and so Withings became Nokia Health. Nokia Health has parted ways with Nokia, and is now Withings again. This caused their API endpoints to change from the account.health.nokia.com domain to the account.withings.com domain.

I do not know if we should then remove the nokiahealth/nokiahealth.go file. I suspect yes, but I would like feedback before doing so.

[gopherbot]

This PR (HEAD: 27b2cd3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/235449 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/235449.
After addressing review feedback, remember to publish your drafts!

[emmaly]

I notice this:

We no longer accept new provider-specific packages in this repo if all they do is add a single endpoint variable. If you just want to add a single endpoint, add it to the godoc.org/golang.org/x/oauth2/endpoints package.

It feels like this is a change from nokiahealth to withings, which is an edit but not an addition, but it probably is more appropriate if this is instead submitted to the endpoints package and then remove nokiahealth from this package. I'm going to leave this open for feedback on correct next steps.

[gopherbot]

This PR (HEAD: 29e5e36) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/235449 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[emmaly]

Commit 29e5e36 is an adjusted proposal to instead remove healthmate from oauth2/healthmate and put it in oauth2/endpoints instead. I wonder if instead of removing it from there, the paths should have been updated to keep any code relying on it from breaking, but using the new paths (even though using the wrong name). I might have simply said healthmate.Endpoint = endpoint.Withings but that would have been circular. I suspect this will be a learning experience for me; sorry if I'm going about this poorly.

[gopherbot]

Message from Chris Broadfoot:

Patch Set 2:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/235449.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/235449.
After addressing review feedback, remember to publish your drafts!