-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Withings Health Mate OAuth2 endpoint #422
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 27b2cd3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/235449 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/235449. |
I notice this:
It feels like this is a change from |
This PR (HEAD: 29e5e36) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/235449 to see it. Tip: You can toggle comments from me using the |
Commit 29e5e36 is an adjusted proposal to instead remove |
Message from Chris Broadfoot: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/235449. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/235449. |
Nokia acquired Withings and so Withings became Nokia Health. Nokia Health has parted ways with Nokia, and is now Withings again. This caused their API endpoints to change from the account.health.nokia.com domain to the account.withings.com domain.
I do not know if we should then remove the
nokiahealth/nokiahealth.go
file. I suspect yes, but I would like feedback before doing so.