oauth2: support PKCE #625

hickford · 2023-01-28T15:02:44Z

Fixes #603

gopherbot · 2023-01-28T15:09:41Z

This PR (HEAD: b582cc0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/463979 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

J0 · 2023-02-06T05:01:26Z

Hey

I'm a user of this package and just wanted to say that better PKCE support would be a great plus for me. Thanks for putting this together and hope this goes through!

gopherbot · 2023-03-10T20:16:25Z

This PR (HEAD: 53a6d31) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/463979 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-04-11T19:40:17Z

This PR (HEAD: bc506f1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/463979 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-04-11T19:52:44Z

This PR (HEAD: 8132a1d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/463979 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2023-04-25T22:45:48Z

This PR (HEAD: e4957e3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/463979 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

oauth2.go

gopherbot · 2023-05-22T05:36:51Z

This PR (HEAD: dccf82c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/463979 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

pkce.go

gopherbot · 2023-07-19T23:08:30Z

This PR (HEAD: 63c89b6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/463979.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-19T23:14:10Z

This PR (HEAD: 601c379) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/463979.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-19T23:19:39Z

This PR (HEAD: f3fd32c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/463979.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-20T07:44:50Z

This PR (HEAD: 44503cf) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/463979.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-07-22T05:44:33Z

This PR (HEAD: 6ea20b1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/463979.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-05T22:34:58Z

Message from Ian Lance Taylor:

Patch Set 21: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-05T22:40:41Z

Message from Go LUCI:

Patch Set 21:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-09-05T22:27:57Z","revision":"55b677bd949c31c8703747520f482b0c6c55a14a"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-05T22:46:26Z

Message from Ian Lance Taylor:

Patch Set 21: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-05T22:46:27Z

Message from Go LUCI:

Patch Set 21:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-05T22:46:28Z

Message from Go LUCI:

Patch Set 21: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T06:37:59Z

Message from Matt Hickford:

Patch Set 22: Commit-Queue+1 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T06:37:59Z

Message from Matt Hickford:

Patch Set 22: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T06:43:56Z

Message from Go LUCI:

Patch Set 22:

CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T06:43:57Z

Message from Go LUCI:

Patch Set 22: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T18:46:18Z

Message from Roland Shoemaker:

Patch Set 22: Run-TryBot+1

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T19:05:45Z

This PR (HEAD: 2a9635e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/463979.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-06T19:37:17Z

This PR (HEAD: 79140ed) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/463979.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-06T19:43:26Z

Message from Matt Hickford:

Patch Set 25: Run-TryBot+1

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T19:50:01Z

Message from Gopher Robot:

Patch Set 25:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-06T19:56:21Z

Message from Gopher Robot:

Patch Set 25: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T16:09:21Z

Message from Roland Shoemaker:

Patch Set 25: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T16:30:37Z

Message from Cherry Mui:

Patch Set 25: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T17:23:27Z

This PR (HEAD: f01f759) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/463979.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-09-07T17:36:47Z

Message from Matt Hickford:

Patch Set 26:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T17:36:48Z

Message from Matt Hickford:

Patch Set 26: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T17:36:49Z

Message from Gopher Robot:

Patch Set 26:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-07T17:43:10Z

Message from Gopher Robot:

Patch Set 26: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/463979.
After addressing review feedback, remember to publish your drafts!

Fixes #603 Fixes golang/go#59835 Change-Id: Ica0cfef975ba9511e00f097498d33ba27dafca0d GitHub-Last-Rev: f01f759 GitHub-Pull-Request: #625 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/463979 Reviewed-by: Cherry Mui <[email protected]> Run-TryBot: Matt Hickford <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]>

gopherbot · 2023-09-07T17:56:03Z

This PR is being closed because golang.org/cl/463979 has been merged.

Fixes golang#603 Fixes golang/go#59835 Change-Id: Ica0cfef975ba9511e00f097498d33ba27dafca0d GitHub-Last-Rev: f01f759 GitHub-Pull-Request: golang#625 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/463979 Reviewed-by: Cherry Mui <[email protected]> Run-TryBot: Matt Hickford <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]>

hickford force-pushed the pkce branch from b582cc0 to 53a6d31 Compare March 10, 2023 20:10

hickford force-pushed the pkce branch from 53a6d31 to bc506f1 Compare April 11, 2023 19:36

hickford force-pushed the pkce branch from bc506f1 to 8132a1d Compare April 11, 2023 19:41

hickford changed the title ~~make PKCE easier~~ support PKCE Apr 11, 2023

hickford changed the title ~~support PKCE~~ oauth2: support PKCE Apr 11, 2023

hickford force-pushed the pkce branch 2 times, most recently from 696f883 to e4957e3 Compare April 25, 2023 22:43

hickford marked this pull request as ready for review April 27, 2023 11:23

jkroepke reviewed May 21, 2023

View reviewed changes

oauth2.go Outdated Show resolved Hide resolved

hickford force-pushed the pkce branch 2 times, most recently from ab098cb to dccf82c Compare May 22, 2023 05:34

wzy9607 suggested changes Jun 19, 2023

View reviewed changes

pkce.go Outdated Show resolved Hide resolved

hickford force-pushed the pkce branch from dccf82c to 63c89b6 Compare July 19, 2023 23:07

hickford force-pushed the pkce branch from 63c89b6 to 601c379 Compare July 19, 2023 23:09

hickford force-pushed the pkce branch from 601c379 to f3fd32c Compare July 19, 2023 23:16

hickford force-pushed the pkce branch from f3fd32c to 44503cf Compare July 20, 2023 07:40

hickford force-pushed the pkce branch from 44503cf to 6ea20b1 Compare July 22, 2023 05:44

hickford force-pushed the pkce branch from 6ea20b1 to 175c42a Compare August 16, 2023 18:58

hickford force-pushed the pkce branch from 17dfe11 to 2a9635e Compare September 6, 2023 19:02

hickford force-pushed the pkce branch from 2a9635e to 79140ed Compare September 6, 2023 19:31

oauth2: support PKCE

f01f759

hickford force-pushed the pkce branch from 79140ed to f01f759 Compare September 7, 2023 17:19

gopherbot closed this Sep 7, 2023

oauth2: support PKCE #625

oauth2: support PKCE #625

Conversation

hickford commented Jan 28, 2023 • edited Loading

gopherbot commented Jan 28, 2023

J0 commented Feb 6, 2023

gopherbot commented Mar 10, 2023

gopherbot commented Apr 11, 2023

gopherbot commented Apr 11, 2023

gopherbot commented Apr 25, 2023

gopherbot commented May 22, 2023

gopherbot commented Jul 19, 2023

gopherbot commented Jul 19, 2023

gopherbot commented Jul 19, 2023

gopherbot commented Jul 20, 2023

gopherbot commented Jul 22, 2023

gopherbot commented Sep 5, 2023

gopherbot commented Sep 5, 2023

gopherbot commented Sep 5, 2023

gopherbot commented Sep 5, 2023

gopherbot commented Sep 5, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 6, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

gopherbot commented Sep 7, 2023

hickford commented Jan 28, 2023 •

edited

Loading