internal/refactor/inline: allow duplicable type conversions #494

vladvalkov · 2024-05-23T22:09:20Z

The current implementation does not consider type conversions to be
duplicable operations; this change resolves it by handling *ast.CallExpr.
All type conversions except []byte(string) and []rune(string) are now
considered to be duplicable.

The change also removes redundant type conversions when typed constants
are passed to inlined functions.

Fixes golang/go#67589

The current implementation does not consider type conversions to be duplicable operations; this change resolves it by handling *ast.CallExpr. All type conversions except []byte(string) and []rune(string) are now considered to be duplicable. The change also removes redundant type conversions when typed constants are passed to inlined functions. Fixes #67589

gopherbot · 2024-05-23T22:21:11Z

This PR (HEAD: f0b08ad) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/588175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-23T22:27:15Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-23T22:33:16Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-24T01:20:13Z

Message from Alan Donovan:

Patch Set 1:

(10 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-24T07:07:36Z

This PR (HEAD: 215fc87) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/588175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-24T07:13:49Z

Message from Vladislav Valkov:

Patch Set 2:

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-24T17:29:09Z

Message from Alan Donovan:

Patch Set 3:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-24T20:33:53Z

This PR (HEAD: a9e9738) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/588175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-24T20:40:21Z

Message from Vladislav Valkov:

Patch Set 3:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-11T13:20:33Z

Message from Vladislav Valkov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-14T19:15:30Z

Message from Alan Donovan:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-17T13:37:42Z

This PR (HEAD: 603b63e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/588175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-17T13:44:37Z

Message from Vladislav Valkov:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-17T15:43:02Z

Message from Alan Donovan:

Patch Set 5: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-17T16:25:27Z

Message from Robert Findley:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-17T16:25:27Z

Message from Robert Findley:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-17T16:32:28Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-17T16:18:56Z","revision":"d8f14b2a75042b857ad6713a04a2f10feed6db46"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-17T16:32:28Z

Message from Robert Findley:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-17T16:32:29Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-arm64 has failed with summary (view all results):

go on master (commit 8f5c690)
tools on master (change 588175)

Build or test failure, click here for results.

Additional links for debugging:

Output for test golang.org/x/tools/gopls module

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-17T16:32:29Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T17:59:07Z

Message from Alan Donovan:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T18:05:50Z

Message from Alan Donovan:

Patch Set 6: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T18:05:50Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-21T17:50:28Z","revision":"ed02bcf85d5948197bbba04eca462b5608525673"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T18:12:13Z

Message from Alan Donovan:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T18:12:13Z

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-go1.19-linux-amd64 has failed with summary (view all results):

go on release-branch.go1.19 (commit 619b8fd)
tools on master (change 588175)

Build or test failure, click here for results.

Additional links for debugging:

Output for test golang.org/x/tools module

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T18:12:14Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T18:51:21Z

This PR (HEAD: 580a00a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/588175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-21T18:57:56Z

Message from Vladislav Valkov:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:11:16Z

Message from Robert Findley:

Patch Set 7: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:17:39Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-21T19:01:30Z","revision":"ee16ce9c97a87159412dd9c3a0b75c39554a0c00"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:17:40Z

Message from Robert Findley:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:17:40Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-arm64 has failed with summary (view all results):

go on master (commit 1b4f1dc)
tools on master (change 588175)

Build or test failure, click here for results.

Additional links for debugging:

Output for test golang.org/x/tools/gopls module

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:17:41Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:17:41Z

Message from Robert Findley:

Patch Set 8: Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:24:18Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-21T19:08:59Z","revision":"79f65fefe742bd411548e845f37621bc1fed3257"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

The current implementation does not consider type conversions to be duplicable operations; this change resolves it by handling *ast.CallExpr. All type conversions except []byte(string) and []rune(string) are now considered to be duplicable. The change also removes redundant type conversions when typed constants are passed to inlined functions. Fixes golang/go#67589 Change-Id: I524dbff1ae09466f56459e0bf3b6425be38d157c GitHub-Last-Rev: 580a00a GitHub-Pull-Request: #494 Reviewed-on: https://go-review.googlesource.com/c/tools/+/588175 Reviewed-by: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Alan Donovan <[email protected]>

gopherbot · 2024-06-21T19:37:35Z

Message from Robert Findley:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:37:35Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:37:35Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/588175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-21T19:43:53Z

This PR is being closed because golang.org/cl/588175 has been merged.

vladvalkov added 4 commits May 24, 2024 01:26

fix: move return to switch

e5d9f8a

doc: comments changed

2147b0f

doc: test description fixed

f0b08ad

vladvalkov added 2 commits May 24, 2024 11:03

fix: review changes

23d363d

fix: fix variable name in the test

215fc87

vladvalkov added 2 commits May 25, 2024 00:26

doc: fixed comments, added a test

f1b6b59

fix: minor refactor

a9e9738

chore: fix explanation, fix used variables

603b63e

fix: fix 1.19 test compatibility

580a00a

gopherbot closed this Jun 21, 2024

internal/refactor/inline: allow duplicable type conversions #494

internal/refactor/inline: allow duplicable type conversions #494

Conversation

vladvalkov commented May 23, 2024 • edited Loading

gopherbot commented May 23, 2024

gopherbot commented May 23, 2024

gopherbot commented May 23, 2024

gopherbot commented May 24, 2024

gopherbot commented May 24, 2024

gopherbot commented May 24, 2024

gopherbot commented May 24, 2024

gopherbot commented May 24, 2024

gopherbot commented May 24, 2024

gopherbot commented Jun 11, 2024

gopherbot commented Jun 14, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

gopherbot commented Jun 21, 2024

vladvalkov commented May 23, 2024 •

edited

Loading