-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopls/internal/undeclaredname: add missing colon when appropriate #545
Conversation
This PR (HEAD: 593ee32) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This PR (HEAD: cfb4da6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from xxx Lulu: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from xxx Lulu: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This PR (HEAD: e55a4db) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
This PR (HEAD: 7fa8370) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
baf803d
to
6d673ec
Compare
This PR (HEAD: 6d673ec) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
This PR (HEAD: bf9874e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
This PR (HEAD: d79fe44) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
This PR (HEAD: baf639f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from Robert Findley: Patch Set 9: (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This PR (HEAD: 977eb21) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from xxx Lulu: Patch Set 10: (8 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Robert Findley: Patch Set 10: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 10: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-27T00:51:17Z","revision":"a25811c8b3a69970453aef84b1d582430bb88ea4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Robert Findley: Patch Set 10: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 10: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64-typesalias has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 10: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Robert Findley: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This PR (HEAD: ee19f4d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from xxx Lulu: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from xxx Lulu: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from xxx Lulu: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Robert Findley: Patch Set 12: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 12: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-27T13:29:23Z","revision":"7a4d9261161bb05001aa311e2fbf837d01a97c31"} Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Robert Findley: Patch Set 12: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 12: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 12: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Veronica Silina: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This PR (HEAD: 5821588) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from xxx Lulu: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from xxx Lulu: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This PR (HEAD: 378bdfd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/629895. Important tips:
|
Message from Robert Findley: Patch Set 13: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 13: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-27T15:54:25Z","revision":"0f34dbddca5ed2118559a3ad4d5a610f05f2d406"} Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 13: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Robert Findley: Patch Set 14: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 14: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-27T16:04:54Z","revision":"e07482eab0be7223c4b2189f2c5a1c8d9ac0c0f0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Robert Findley: Patch Set 14: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 14: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
Message from Go LUCI: Patch Set 14: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/629895. |
This CL improves the undeclared-variable quick fix by adding the missing colon when appropriate, that is: 1) When the first occurrence of undefined ident's parent within function is an AssignStmt, and it sits in the left hand side; 2) Its Tok is set to token.ASSIGN (=); 3) Ident must not be self assignment. Prior to this CL: 1) the new generated one simply sits above the cursor position, while this CL insert it before the first undefined ident with the same name. 2) It results in a syntax error, as stated in https://go-review.googlesource.com/c/tools/+/623156/comment/09944936_9d2835c2/, so this CL also adds a default value derived from its type. Fixes golang/go#69980 Change-Id: I4ccad852f89bc60034ade856ad5b1490686fc1e8 GitHub-Last-Rev: 378bdfd GitHub-Pull-Request: #545 Reviewed-on: https://go-review.googlesource.com/c/tools/+/629895 Auto-Submit: Robert Findley <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Robert Findley <[email protected]> Reviewed-by: Veronica Silina <[email protected]>
This PR is being closed because golang.org/cl/629895 has been merged. |
This CL improves the undeclared-variable quick fix
by adding the missing colon when appropriate, that is:
function is an AssignStmt, and it sits in the left hand side;
Prior to this CL:
the cursor position, while this CL insert it before the first
undefined ident with the same name.
so this CL also adds a default value derived from its type.
Fixes golang/go#69980