Skip to content

internal/refactor/inline: improve package local name by preserving alias #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

internal/refactor/inline: improve package local name by preserving alias #601

wants to merge 1 commit into from
+81 −20

Conversation

@gavinkflam
Copy link

@gavinkflam gavinkflam commented Oct 20, 2025 •
edited
Loading

The existing implementation generates package local names by appending
a numeric suffix to package name, which reduces readability.

This improvement preserves existing import alias when available and
fall back to the existing name generation mechanism if a conflict occurs.

Updates golang/go#63352
Fixes golang/go#74965

@gopherbot
Copy link
Contributor

This PR (HEAD: 37368b6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712981.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gavin Lam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-21T15:33:31Z","revision":"52a26e43227e83b56db65b17d9e59e2f43a541a8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from t hepudds:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64-race has failed with summary (view all results):

To reproduce, try gomote repro 8700387610345756337.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gavinkflam gavinkflam changed the title internal/refactor/inline: preserve alias when choosing a local name for imported package internal/refactor/inline: improve package local name by preserving alias Oct 22, 2025
@gopherbot
Copy link
Contributor

Message from Gavin Lam:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gavin Lam:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

@gavinkflam
internal/refactor/inline: improve package local name by preserving alias
5a7a316 
The existing implementation generates package local names by appending
a numeric suffix to package name, which reduces readability.

This improvement preserves existing import alias when available and
fall back to the existing name generation mechanism if a conflict occurs.

Updates golang/go#63352
Fixes golang/go#74965

Signed-off-by: Gavin Lam <[email protected]>
@gavinkflam gavinkflam force-pushed the 74965-inline-preserve-import-alias branch from 37368b6 to 5a7a316 Compare October 22, 2025 22:40
@gopherbot
Copy link
Contributor

This PR (HEAD: 5a7a316) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712981.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gavin Lam:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

x/tools/internal/refactor/inline: choose better local names for renaming imports

2 participants

@gavinkflam @gopherbot