feat: add uncalled linter

.golangci.reference.yml

@@ -1746,6 +1746,37 @@ linters-settings:
       # Default: true
       begin: false
 
+  uncalled:
+    # Disables all rules.
+    # Default: false
+    disabled-all: true
+    # Disables the given rules.
+    # Default: []
+    disabled:
+      - context-cancel
+    # Enables specific rules, in combination with disable all.
+    # Default: []
+    enabled:
+      - sql-rows-err
+    # Add or override default rules.
+    # Default: []
+    rules:
+      # Check for missing context CancelFunc() calls.
+      - name: context-cancel
+        category: context
+        packages:
+          - context
+        methods: []
+        results:
+          - type: .Context
+            pointer: false
+          - type: .CancelFunc
+            pointer: false
+            expect:
+              call:
+              args: []
+
+
   usestdlibvars:
     # Suggest the use of http.MethodXX.
     # Default: true
@@ -2052,6 +2083,7 @@ linters:
     - thelper
     - tparallel
     - typecheck
+    - uncalled
     - unconvert
     - unparam
     - unused
@@ -2159,6 +2191,7 @@ linters:
     - thelper
     - tparallel
     - typecheck
+    - uncalled
     - unconvert
     - unparam
     - unused

go.mod

@@ -93,6 +93,7 @@ require (
 	github.com/spf13/viper v1.12.0
 	github.com/ssgreg/nlreturn/v2 v2.2.1
 	github.com/stbenjam/no-sprintf-host-port v0.1.1
+	github.com/stevenh/go-uncalled v0.8.1
 	github.com/stretchr/testify v1.8.1
 	github.com/tdakkota/asciicheck v0.1.1
 	github.com/tetafro/godot v1.4.11
@@ -162,6 +163,7 @@ require (
 	github.com/quasilyte/gogrep v0.0.0-20220828223005-86e4605de09f // indirect
 	github.com/quasilyte/regex/syntax v0.0.0-20200407221936-30656e2c4a95 // indirect
 	github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect
+	github.com/rs/zerolog v1.28.0 // indirect
 	github.com/sivchari/nosnakecase v1.7.0
 	github.com/spf13/afero v1.8.2 // indirect
 	github.com/spf13/cast v1.5.0 // indirect

pkg/config/linters_settings.go

@@ -4,6 +4,7 @@ import (
 	"runtime"
 
 	"github.com/pkg/errors"
+	"github.com/stevenh/go-uncalled/pkg/uncalled"
 )
 
 var defaultLintersSettings = LintersSettings{
@@ -108,6 +109,12 @@ var defaultLintersSettings = LintersSettings{
 		SkipRegexp:    `(export|internal)_test\.go`,
 		AllowPackages: []string{"main"},
 	},
+	Uncalled: UncalledSettings{
+		DisableAll: false,
+		Enabled:    nil,
+		Disabled:   nil,
+		Rules:      nil,
+	},
 	Unparam: UnparamSettings{
 		Algo: "cha",
 	},
@@ -198,6 +205,7 @@ type LintersSettings struct {
 	Tenv             TenvSettings
 	Testpackage      TestpackageSettings
 	Thelper          ThelperSettings
+	Uncalled         UncalledSettings
 	Unparam          UnparamSettings
 	Unused           StaticCheckSettings
 	UseStdlibVars    UseStdlibVarsSettings
@@ -667,6 +675,8 @@ type UseStdlibVarsSettings struct {
 	SyslogPriority     bool `mapstructure:"syslog-priority"`
 }
 
+type UncalledSettings = uncalled.Config
+
 type UnparamSettings struct {
 	CheckExported bool `mapstructure:"check-exported"`
 	Algo          string

pkg/golinters/uncalled.go

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/stevenh/go-uncalled/pkg/uncalled"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewUncalled(settings *config.UncalledSettings) *goanalysis.Linter {
+	a := uncalled.NewAnalyzer(uncalled.ConfigOpt(settings))
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/lint/lintersdb/manager.go

@@ -166,6 +166,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 		tenvCfg             *config.TenvSettings
 		testpackageCfg      *config.TestpackageSettings
 		thelperCfg          *config.ThelperSettings
+		uncalledCfg         *config.UncalledSettings
 		unparamCfg          *config.UnparamSettings
 		unusedCfg           *config.StaticCheckSettings
 		usestdlibvars       *config.UseStdlibVarsSettings
@@ -242,6 +243,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 		tenvCfg = &m.cfg.LintersSettings.Tenv
 		testpackageCfg = &m.cfg.LintersSettings.Testpackage
 		thelperCfg = &m.cfg.LintersSettings.Thelper
+		uncalledCfg = &m.cfg.LintersSettings.Uncalled
 		unparamCfg = &m.cfg.LintersSettings.Unparam
 		unusedCfg = &m.cfg.LintersSettings.Unused
 		varcheckCfg = &m.cfg.LintersSettings.Varcheck
@@ -787,6 +789,12 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetBugs).
 			WithURL(""),
 
+		linter.NewConfig(golinters.NewUncalled(uncalledCfg)).
+			WithSince("v1.51.0").
+			WithLoadForGoAnalysis().
+			WithPresets(linter.PresetBugs, linter.PresetSQL).
+			WithURL("https://github.com/stevenh/go-uncalled"),
+
 		linter.NewConfig(golinters.NewUnconvert()).
 			WithSince("v1.0.0").
 			WithLoadForGoAnalysis().

test/linters_test.go

@@ -30,6 +30,7 @@ func TestTypecheck(t *testing.T) {
 func TestSourcesFromTestdataSubDir(t *testing.T) {
 	subDirs := []string{
 		"loggercheck",
+		"uncalled",
 	}
 
 	for _, dir := range subDirs {

test/testdata/uncalled/uncalled.go

@@ -0,0 +1,17 @@
+//golangcitest:args -Euncalled
+package testdata
+
+import (
+	"database/sql"
+)
+
+func RowsErrNotChecked(db *sql.DB) {
+	rows, err := db.Query("select id from tb") // want "rows.Err\\(\\) must be called"
+	if err != nil {
+		// Handle error.
+	}
+
+	for rows.Next() {
+		// Handle row.
+	}
+}