Open
Conversation
- fix age label and hour default - refactor interpretation prefix pattern - add currentYear to SajuResult - unify type property names to camelCase - extract sal lookup tables to module level - add typecheck script Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review improvements for ssaju library.
Bug Fixes
만 X세toX세(Korean age was mislabeled as international age)Refactoring
generateInterpretationno longer adds prefix,format.tsno longer strips it)currentYearfield toSajuResult, removed fragile reverse-calculation informat.tsWolunItem:month_name->monthName,stem_tengod->stemTenGod,branch_tengod->branchTenGodDaeunItem/WolunItem:12unsung->stage12Chore
typecheckscript (tsc --noEmit)Verification