Skip to content

Bound col_starts indices in TrackingData motion-vector decoding (heap OOB read) #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
evilgensec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bound col_starts indices in TrackingData motion-vector decoding (heap OOB read) #6311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions mediapipe/util/tracking/tracking.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3218,6 +3218,15 @@ void MotionVectorFrameFromTrackingData(const TrackingData& tracking_data,
for (int r = motion_data.col_starts(c),
r_end = motion_data.col_starts(c + 1);
r < r_end; ++r) {
// Guard against a malformed TrackingData whose col_starts reference
// indices outside the dependent repeated fields (heap OOB read
// otherwise). col_starts is attacker-controlled and independent of the
// row_indices/vector_data/track_id sizes.
if (r < 0 || r >= motion_data.row_indices_size() ||
2 * r + 1 >= motion_data.vector_data_size() ||
(long_tracks && r >= motion_data.track_id_size())) {
break;
}
MotionVector motion_vector;

const float y = motion_data.row_indices(r);
Expand Down Expand Up @@ -3278,6 +3287,12 @@ void FeatureAndDescriptorFromTrackingData(
for (int r = motion_data.col_starts(c),
r_end = motion_data.col_starts(c + 1);
r < r_end; ++r) {
// Same guard as MotionVectorFrameFromTrackingData: reject col_starts
// values that fall outside the dependent repeated fields.
if (r < 0 || r >= motion_data.feature_descriptors_size() ||
r >= motion_data.row_indices_size()) {
break;
}
const std::string& descriptor = motion_data.feature_descriptors(r).data();

if (absl::c_all_of(descriptor, [](char c) { return c == 0; })) {
Expand Down