Fix gin-config compatibility error in rl_unplugged notebooks#672
Open
Aamod007 wants to merge 1 commit intogoogle-deepmind:masterfrom
Open
Fix gin-config compatibility error in rl_unplugged notebooks#672Aamod007 wants to merge 1 commit intogoogle-deepmind:masterfrom
Aamod007 wants to merge 1 commit intogoogle-deepmind:masterfrom
Conversation
|
Dooray! Failure Notice
Failure Notice
Your message sent to
***@***.***)
has failed to be delivered.
Please refer to the below for details.
* Recipient :
***@***.***)
* Sent time :
2026-01-09T03:15:47
* Subject :
[google-deepmind/deepmind-research] Fix gin-config compatibility error in rl_unplugged notebooks (PR #672)
* Remote host said :
Your mail was denied from the receiver.
This message was sent from a notification-only address that cannot accept incoming email.
For more information, please contact ***@***.***
© Dooray!.
|
…nd#428) Pin gin-config==0.3.0 in atari_dqn.ipynb and bsuite.ipynb install cells to match requirements.txt and avoid TypeError from dopamine-rl using the deprecated 'blacklist' parameter in newer gin-config versions.
eadc2bc to
b0f300a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428
Problem
Running
from rl_unplugged import atariin Colab raises:TypeError: configurable() got an unexpected keyword argument 'blacklist'This occurs because
dopamine-rl==3.1.2uses gin-config's deprecatedblacklistparameter, which was renamed todenylistin newer gin-config versions.Solution
Pin
gin-config==0.3.0in the notebook installation cells, consistent with what's already specified inrequirements.txt.Changes
atari_dqn.ipynb: Added!pip install gin-config==0.3.0before dopamine-rlbsuite.ipynb: Added!pip install gin-config==0.3.0before dopamine-rlNote: The
dmlab_r2d2.ipynbbazel build issue mentioned in #428 is a separate infrastructure problem with DeepMind Lab that requires upstream fixes.