Fixed bug in Ultimate Tic Tac Toe termination conditions #1307
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end when any small board was terminal instead of when *all* small boards are terminal
|
Thanks! |
|
Regarding the failing tests: seems like a new issue in Dark Hex is causing a compilation problem that wasn't happening before. I am on vacation at the moment but will take a look when I get back next week. Once we fix it you can just pull the changes from master and retrigger the tests. |
Ok, this fix has been merged into master. Can you pull changes from master and push the merge commit to trigger the tests again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in Ultimate Tic Tac Toe implementation that caused games to end when any small board was terminal instead of when all small boards are terminal