Skip to content

fix: handle google.genai exceptions and guard colab imports #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pratz1337 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle google.genai exceptions and guard colab imports #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion strategicwm/_src/client_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,15 @@ def __str__(self) -> str:
f"{self.original_http_error.args[0]}")


RETRIABLE_EXCEPTIONS = (
HttpErrorRetriable,
genai.errors.ServerError,
genai.errors.APIError,
)


@retry.retry(
exceptions=HttpErrorRetriable,
exceptions=RETRIABLE_EXCEPTIONS,
tries=10,
delay=10,
max_delay=60,
Expand Down
23 changes: 14 additions & 9 deletions strategicwm/_src/se/visualization/game_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
import re

import bs4
from google.colab import output
try:
from google.colab import output
except ImportError:
output = None
from IPython import display as display_html
import ipywidgets as widgets
import networkx as nx
Expand Down Expand Up @@ -138,8 +141,9 @@ def html_from_nx(self) -> str:
soup = bs4.BeautifulSoup(html_content, "html.parser")

# Register BOTH functions with unique names
output.register_callback("set_node_selection", self.set_node_selection)
output.register_callback("set_path_selection", self.set_path_selection)
if output:
output.register_callback("set_node_selection", self.set_node_selection)
output.register_callback("set_path_selection", self.set_path_selection)

js_modifications = """
var node_select_ts = null;
Expand Down Expand Up @@ -457,12 +461,13 @@ def display_html(self, html_content: str):
html_widget = widgets.HTML(value=html_content)
display_html.display(html_widget)

iframe_height = 2000
iframe_height_js = (
"google.colab.output.setIframeHeight(0, true, "
+ f"{{maxHeight: {iframe_height}}})"
)
display_html.display(display_html.Javascript(iframe_height_js))
if output:
iframe_height = 2000
iframe_height_js = (
"google.colab.output.setIframeHeight(0, true, "
+ f"{{maxHeight: {iframe_height}}})"
)
display_html.display(display_html.Javascript(iframe_height_js))

def show_tree(self):
html_content = self.html_from_nx()
Expand Down