Guard against division by zero in JAX where clauses.#2138
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_905282614
branch
2 times, most recently
from
April 29, 2026 17:38
902c921 to
0291eae
Compare
This change adds checks to prevent division by zero in calculations involving impurity properties where Z_eff=1.0 (no impurities), particularly within jnp.where expressions. Since JAX evaluates both branches of jnp.where, denominators must be non-zero even in the branch that is logically not taken, to avoid JAX sharp edges. PiperOrigin-RevId: 907672167
copybara-service
Bot
force-pushed
the
test_905282614
branch
from
April 29, 2026 17:52
0291eae to
cc46db9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard against division by zero in JAX where clauses.
This change adds checks to prevent division by zero in calculations involving impurity properties where Z_eff=1.0 (no impurities), particularly within jnp.where expressions. Since JAX evaluates both branches of jnp.where, denominators must be non-zero even in the branch that is logically not taken, to avoid JAX sharp edges.