Simplify safety factor statistics calculation.#2288
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_947773274
branch
from
July 15, 2026 09:17
8c55477 to
2655fd4
Compare
copybara-service
Bot
force-pushed
the
test_947773274
branch
from
July 16, 2026 16:50
2655fd4 to
f29bec0
Compare
Replace the error prone quadratic fitting routine with simpler logic. For q min we simply return the min value. For the intercepts we do linear interpolation of each interval and look for potential intercepts in each interval. This fits better with making fewer assumptions on the underlying profile and fixes the buggy values returned by quadratic fits. PiperOrigin-RevId: 949037347
copybara-service
Bot
force-pushed
the
test_947773274
branch
from
July 16, 2026 17:14
f29bec0 to
e7b4e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify safety factor statistics calculation.
Replace the error prone quadratic fitting routine with simpler logic.
For q min we simply return the min value.
For the intercepts we do linear interpolation of each interval and look for potential intercepts in each interval.
This fits better with making fewer assumptions on the underlying profile and fixes the buggy values returned by quadratic fits.