Flatten __call__ and simplify _combine in CombinedTransportModel. - #2362
Open
copybara-service[bot] wants to merge 1 commit into
Open
Flatten __call__ and simplify _combine in CombinedTransportModel.#2362copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
- Merge call_implementation() body into __call__(), removing the separate method. __call__ now directly combines core and pedestal coefficients, applies clipping, and applies smoothing. - Simplify _combine loop: call model() directly instead of separate model.call_implementation() + model.zero_out_disabled_channels(), since ComponentTransportModel.__call__ now wraps both. - Update combined_test.py to call model() instead of model.call_implementation(). PiperOrigin-RevId: 964556808
copybara-service
Bot
force-pushed
the
test_964556808
branch
from
August 14, 2026 09:56
306189f to
12872c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flatten call and simplify _combine in CombinedTransportModel.