Decentralize EdgeModelOutputs and ExtendedLengyelOutputs to xarray conversion. - #2367
Open
copybara-service[bot] wants to merge 1 commit into
Open
Decentralize EdgeModelOutputs and ExtendedLengyelOutputs to xarray conversion.#2367copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…nversion. Refactors edge model output serialization so that EdgeModelOutputs and ExtendedLengyelOutputs manage their own output dictionary and DataTree construction: - Adds EdgeModelOutputs.to_output_dict(context) and .to_xr_datatree(context). - Adds ExtendedLengyelOutputs.to_output_dict(context), ._process_roots_output(), and .to_xr_datatree(context). - Initializes self._output_grid_context on StateHistory to provide spatial/temporal coordinates for output conversion. - Simplifies StateHistory._save_edge_outputs() to delegate directly to self._stacked_edge_outputs.to_xr_datatree(self._output_grid_context). This eliminates centralized, model-specific edge extraction logic in output.py in accordance with TORAX design guidelines (avoiding God Objects for I/O), making edge model serialization modular and polymorphic. PiperOrigin-RevId: 963991202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decentralize EdgeModelOutputs and ExtendedLengyelOutputs to xarray conversion.
Refactors edge model output serialization so that EdgeModelOutputs and
ExtendedLengyelOutputs manage their own output dictionary and DataTree
construction:
and .to_xr_datatree(context).
spatial/temporal coordinates for output conversion.
self._stacked_edge_outputs.to_xr_datatree(self._output_grid_context).
This eliminates centralized, model-specific edge extraction logic in
output.py in accordance with TORAX design guidelines (avoiding God Objects
for I/O), making edge model serialization modular and polymorphic.