Bug fixes and Imagen 3 support for scaled version #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-paunescu
requested changes
Feb 19, 2025
| files.push(filesIterator.next()); | ||
| const file = filesIterator.next(); | ||
| console.log( | ||
| `Reading file: ${file.getName()} with mime type: ${file.getMimeType()}` |
There was a problem hiding this comment.
Should we remove the logging message?
| @@ -184,16 +195,49 @@ export class AppComponent implements OnInit { | |||
| }); | |||
| } | |||
|
|
|||
| createVertexAiCall(current: ImageQueue) { | |||
| // TODO(): Update it for imagen 3. | |||
| } | ||
|
|
||
| getImagenRequestBody(prompt: string, imageBase64: string) { | ||
| if (this.modelId.startsWith('imagegeneration@')) { |
There was a problem hiding this comment.
nit: Ideally I guess we could have constants for the model, since it's also shown on the UI.
| referenceId: 2, | ||
| maskImageConfig: { | ||
| maskMode: 'MASK_MODE_BACKGROUND', | ||
| dilation: 0.0, |
There was a problem hiding this comment.
Perhaps we could support this as a parameter in the UI in the future
| negativePrompt: '', | ||
| promptLanguage: 'en', | ||
| editConfig: { | ||
| baseSteps: 75, |
| }); | ||
| } else if (modelId.startsWith('imagen-3.0')) { | ||
| if (backgroundRemoval) { | ||
| return createRequestOptions({ |
There was a problem hiding this comment.
Perhaps in the future we could refactor this and the above duplicated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where larger sized images and jpeg images were not generated. Also adds support for Imagen 3 on the scaled version.