-
Notifications
You must be signed in to change notification settings - Fork 979
Enhance CI for Samples: Build, Test, and Smoke Tests #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacobsimionato
wants to merge
7
commits into
google:main
Choose a base branch
from
jacobsimionato:ci_samples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1690364
chore: enhance CI for samples with build, test, and smoke tests
jacobsimionato 7bede16
chore: add lit smoke tests, explicit typechecking, and python agent v…
jacobsimionato 0bd542f
fix(ci): fix lit smoke tests by using tsx and fix angular typecheck a…
jacobsimionato 829b863
fix(ci): add tsx to devDeps for lit samples and remove invalid ng arg
jacobsimionato 6aed950
fix(ci): fix CI failures by adding missing tsx dep and simplifying an…
jacobsimionato 1574ebe
fix(ci): add missing tsconfig.spec.json for gallery and further fix CI
jacobsimionato 8f7f2c2
Merge branch 'main' into ci_samples
zeroasterisk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
samples/client/angular/projects/gallery/tsconfig.spec.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "extends": "../../tsconfig.json", | ||
| "compilerOptions": { | ||
| "outDir": "../../out-tsc/spec", | ||
| "types": [ | ||
| "jasmine" | ||
| ] | ||
| }, | ||
| "include": [ | ||
| "src/**/*.ts" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ | |
| "service": true | ||
| }, | ||
| "test": { | ||
| "command": "node --test --enable-source-maps --test-reporter spec dist/src/0.8/tests/**/*.test.js", | ||
| "command": "npx tsx --test --test-reporter spec tests/**/*.test.ts", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. YES! Good fix! |
||
| "dependencies": [ | ||
| "build" | ||
| ] | ||
|
|
@@ -62,6 +62,7 @@ | |
| "devDependencies": { | ||
| "dotenv": "^17.2.3", | ||
| "typescript": "^5.8.3", | ||
| "tsx": "^4.19.0", | ||
| "uuid": "^13.0.0", | ||
| "vite": "^7.1.11", | ||
| "wireit": "^0.15.0-pre.2" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { test } from 'node:test'; | ||
| import assert from 'node:assert'; | ||
| import '../component-gallery.ts'; | ||
| import '../client.ts'; | ||
|
|
||
| test('smoke test: component_gallery imports resolve', () => { | ||
| assert.ok(true); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { test } from 'node:test'; | ||
| import assert from 'node:assert'; | ||
| import '../contact.ts'; | ||
| import '../client.ts'; | ||
|
|
||
| test('smoke test: contact imports resolve', () => { | ||
| assert.ok(true); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { test } from 'node:test'; | ||
| import assert from 'node:assert'; | ||
| import '../app.ts'; | ||
| import '../client.ts'; | ||
|
|
||
| test('smoke test: shell imports resolve', () => { | ||
| assert.ok(true); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be a configurable python script in
scriptsor similar that reads what class to import from the command line maybe? That way this line can become something likeuv run python smoke_test.py RizzchartsAgent?