Fix publishing workflow and update scripts for web packages by jacobsimionato · Pull Request #768 · google/A2UI

jacobsimionato · 2026-03-04T05:20:10Z

These are to use temporarily while set up the automated pipeline properly.

gemini-code-assist

Code Review

This pull request introduces manual publishing instructions for the web_core package, including necessary configuration files and updates to package.json. The documentation is a good addition for the temporary manual process. However, I've noticed that the new PUBLISHING.md file contains hardcoded version numbers, which can become outdated and lead to errors. I've added a couple of suggestions to replace these with more generic placeholders to improve the long-term maintainability of the document.

_{Note: Security Review has been skipped due to the limited scope of the PR.}

gemini-code-assist · 2026-03-04T05:21:54Z

renderers/web_core/PUBLISHING.md

+
+Ensure your local repository is clean and on the correct branch (e.g., `main`).
+
+1.  **Check Version:** Ensure the `version` in `package.json` is set correctly. For the current release, it should be `"0.8.0"`.


Hardcoding the version number "0.8.0" in the documentation can lead to errors in future releases if a developer forgets to update this line. It's better to provide a general instruction without a specific, hardcoded version.

Suggested change

1. **Check Version:** Ensure the `version` in `package.json` is set correctly. For the current release, it should be `"0.8.0"`.

1. **Check Version:** Ensure the `version` in `package.json` is set to the correct version for the release.

gemini-code-assist · 2026-03-04T05:21:54Z

renderers/web_core/PUBLISHING.md

+## 6. Post-publish (Optional but recommended)
+
+After a successful publish:
+1. Create a git tag for the release (e.g., `git tag v0.8.0`).


Similar to the version check, this hardcoded version in the git tag example will become outdated. Using a generic placeholder or a non-specific example is more maintainable and less prone to causing confusion for future releases.

Suggested change

1. Create a git tag for the release (e.g., `git tag v0.8.0`).

1. Create a git tag for the release (e.g., `git tag v1.2.3`).

ditman · 2026-03-04T19:19:08Z

renderers/web_core/PUBLISHING.md

Can't wait to deprecate this flow :P

gspencergoog

Thanks for writing this up!

gspencergoog · 2026-03-05T17:32:34Z

renderers/markdown/markdown-it/prepare-publish.mjs

@@ -0,0 +1,85 @@
+import { readFileSync, writeFileSync, copyFileSync, mkdirSync, existsSync } from 'fs';


ditman

Thanks for getting the markdown-it to a publishable state, this is fantastic!

Small comment about the dependencies for web_core. The whole build post-processing happened because web_core got pushed to the repo without being published to npm. Now that the package is published, we don't need any of that. Local development should happen with npm link or workspaces (I don't know yet :P)

ditman · 2026-03-05T18:10:17Z

renderers/angular/postprocess-build.mjs

@@ -38,6 +38,12 @@ if (!packageJson.dependencies['@a2ui/web_core']) {
 }

 packageJson.dependencies['@a2ui/web_core'] = '^' + coreVersion;


I think we should stop post-processing the web_core dependency, and instead, take a dependency on the version of the package that's published on npm. That way, these build script could be simplified quite a lot! WDYT?

Then, we'd need some instructions on how to develop locally to be able to modify multiple packages at once, with workspaces, or npm link (?)

my 2¢ is a npm link workflow is probably the best way to approach this, whenever we document that.

ditman · 2026-03-05T18:12:33Z

renderers/markdown/markdown-it/prepare-publish.mjs

+// 3. Adjusting paths in package.json (main, types, exports) to be relative to dist/
+
+const dirname = import.meta.dirname;
+const corePkgPath = join(dirname, '../../web_core/package.json');


This package is going to be fairly stable, and it most likely won't need a lot of changes to web_core. Can you please update the package.json to take a dependency on the published version of web_core? Maybe we can remove most of this file?

ditman · 2026-03-05T18:13:47Z

renderers/web_core/package.json

 {
  "name": "@a2ui/web_core",
-  "version": "0.8.2",
+  "version": "0.8.0",


Would it make sense to call this fix 0.8.1 and publish the package, so the package.json version matches what's published (not retroactively? :P)

Update publishing instructions

8878cb0

jacobsimionato requested review from ava-cassiopeia, ditman and paullewis as code owners March 4, 2026 05:20

github-project-automation bot added this to A2UI Mar 4, 2026

github-project-automation bot moved this to Todo in A2UI Mar 4, 2026

gemini-code-assist bot reviewed Mar 4, 2026

View reviewed changes

ditman approved these changes Mar 4, 2026

View reviewed changes

renderers/web_core/PUBLISHING.md Outdated

Copy link

Collaborator

ditman Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to deprecate this flow :P

Fix publishing process

2e6a382

jacobsimionato requested review from crisbeto, dmandar, gspencergoog, nan-yu, yjbanov and zeroasterisk as code owners March 5, 2026 04:58

jacobsimionato changed the title ~~Update manual publishing instructions for web_core~~ Fix publishing workflow and update scripts for web packages Mar 5, 2026

jacobsimionato added 2 commits March 5, 2026 15:31

Remove old guide

78d9db3

Reinstate .npmrc

f1a90dc

gspencergoog approved these changes Mar 5, 2026

View reviewed changes

ditman approved these changes Mar 5, 2026

View reviewed changes

ava-cassiopeia approved these changes Mar 6, 2026

View reviewed changes

This comment was marked as spam.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix publishing workflow and update scripts for web packages#768

Fix publishing workflow and update scripts for web packages#768
jacobsimionato wants to merge 4 commits intogoogle:mainfrom
jacobsimionato:publish

jacobsimionato commented Mar 4, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 4, 2026

Uh oh!

gemini-code-assist bot Mar 4, 2026

Uh oh!

ditman Mar 4, 2026

Uh oh!

gspencergoog left a comment

Uh oh!

gspencergoog Mar 5, 2026

Uh oh!

ditman left a comment

Uh oh!

ditman Mar 5, 2026

Uh oh!

ava-cassiopeia Mar 6, 2026

Uh oh!

ditman Mar 5, 2026

Uh oh!

ditman Mar 5, 2026

Uh oh!

This comment was marked as spam.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		Ensure your local repository is clean and on the correct branch (e.g., `main`).

		1. Check Version: Ensure the `version` in `package.json` is set correctly. For the current release, it should be `"0.8.0"`.

	1. Create a git tag for the release (e.g., `git tag v0.8.0`).
	1. Create a git tag for the release (e.g., `git tag v1.2.3`).

		@@ -0,0 +1,85 @@
		import { readFileSync, writeFileSync, copyFileSync, mkdirSync, existsSync } from 'fs';

		@@ -38,6 +38,12 @@ if (!packageJson.dependencies['@a2ui/web_core']) {
		}

		packageJson.dependencies['@a2ui/web_core'] = '^' + coreVersion;

Conversation

jacobsimionato commented Mar 4, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

ditman Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

gspencergoog Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

ditman Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

ava-cassiopeia Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

ditman Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

ditman Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants